From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH 1 of 5] Support getting topology info in libxl Date: Thu, 09 Dec 2010 14:19:44 +0100 Message-ID: <4D00D770.1080405@ts.fujitsu.com> References: <1291900308.20366.1.camel@qabil.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1291900308.20366.1.camel@qabil.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Gianni Tedesco Cc: "xen-devel@lists.xensource.com" , Ian Jackson List-Id: xen-devel@lists.xenproject.org Ian, could you take my previous version of this patch (1 of 5), or would you like me to send another complete patch series? Juergen On 12/09/10 14:11, Gianni Tedesco wrote: > On Thu, 2010-12-09 at 12:39 +0000, Juergen Gross wrote: >> >> +PyObject *attrib__libxl_cpuarray_get(libxl_cpuarray *pptr) >> +{ >> + PyObject *list = NULL; >> + int i; >> + >> + list = PyList_New(0); >> + for (i = 0; i< pptr->entries; i++) { >> + if (pptr->array[i] == LIBXL_CPUARRAY_INVALID_ENTRY) { >> + PyList_Append(list, Py_None); >> + Py_INCREF(Py_None); > > > Actually I think I am the one who is confused. It is the other way > around. I need to fix other places that leak references due to this. > > IOW, this was good to go first time around, tried to respond earlier but > my mail client barfed the message. > > Sorry for the noise! :( -- Juergen Gross Principal Developer Operating Systems TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com Domagkstr. 28 Internet: ts.fujitsu.com D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html