xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: regression from -unstable c/s 21812:e382656e4dcc (noticed in 4.0.1)
Date: Mon, 13 Dec 2010 09:18:13 +0000	[thread overview]
Message-ID: <4D05F2E502000078000277F7@vpn.id2.novell.com> (raw)

Keir,

without the use of dom0_mem= reserving sufficiently much memory,
this change causes a regression as the calculation of the Dom0
allocation doesn't account for the memory consumed by
iommu_dom0_init(). With enough memory in the system, this may
run Xen out of memory altogether, in particular preventing Dom0
from setting up its swiotlb (and pointing out lack of error handling,
as it's very unlikely for hd->platform_ops->dom0_init() to have
succeeded when afterwards there's not a single page left available).

To me it's not immediately clear what the best fix for this problem
is: Either there needs to be another hook into iommu code to
pre-calculate the memory needs, or the !strict case needs to be
handled earlier again (under [questionable] the assumption that
someone forcing strict mode will know to also pass a suitable
dom0_mem=).

Thanks, Jan

             reply	other threads:[~2010-12-13  9:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-13  9:18 Jan Beulich [this message]
2010-12-13  9:29 ` regression from -unstable c/s 21812:e382656e4dcc (noticed in 4.0.1) Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D05F2E502000078000277F7@vpn.id2.novell.com \
    --to=jbeulich@novell.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).