From: "Jan Beulich" <JBeulich@novell.com>
To: xen-devel@lists.xensource.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Konrad Rzeszutek Wilk <konrad@kernel.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
linux-kernel@vger.kernel.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 9/9] xen/xen-pciback: Swap over to DEFINE_PCI_DEVICE_TABLE
Date: Tue, 14 Dec 2010 10:08:21 +0000 [thread overview]
Message-ID: <4D0750250200007800027C67@vpn.id2.novell.com> (raw)
In-Reply-To: <1292263303-31680-10-git-send-email-konrad.wilk@oracle.com>
>>> On 13.12.10 at 19:01, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> drivers/xen/pciback/pci_stub.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/xen/pciback/pci_stub.c b/drivers/xen/pciback/pci_stub.c
> index c8f6f29..09dd60c 100644
> --- a/drivers/xen/pciback/pci_stub.c
> +++ b/drivers/xen/pciback/pci_stub.c
> @@ -497,7 +497,7 @@ static void pcistub_remove(struct pci_dev *dev)
> }
> }
>
> -static const struct pci_device_id pcistub_ids[] = {
> +DEFINE_PCI_DEVICE_TABLE(pcistub_ids) = {
> {
> .vendor = PCI_ANY_ID,
> .device = PCI_ANY_ID,
You shouldn't drop "static" here.
Jan
prev parent reply other threads:[~2010-12-14 10:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 18:01 [PATCH v2] Xen PCI backend driver Konrad Rzeszutek Wilk
2010-12-13 18:01 ` [PATCH 1/9] xen: export xen_gsi_from_irq, it is required by modular pciback Konrad Rzeszutek Wilk
2010-12-13 18:01 ` [PATCH 2/9] xen/pci: Add xen_[find|register|unregister]_device_domain_owner functions Konrad Rzeszutek Wilk
2010-12-13 19:28 ` Jeremy Fitzhardinge
2010-12-13 18:01 ` [PATCH 3/9] xen: Check if the PCI device is owned by a domain different than DOMID_SELF Konrad Rzeszutek Wilk
2010-12-13 18:01 ` [PATCH 4/9] xen: Add support to check if IRQ line is shared with other domains Konrad Rzeszutek Wilk
2010-12-13 19:34 ` Jeremy Fitzhardinge
2010-12-13 18:01 ` [PATCH 5/9] xen: implement bind_interdomain_evtchn_to_irqhandler for backend drivers Konrad Rzeszutek Wilk
2010-12-13 18:01 ` [PATCH 6/9] pci/xen: Make xen_[find|register|unregister]_domain_owner be _GPL Konrad Rzeszutek Wilk
2010-12-13 19:18 ` Jeremy Fitzhardinge
2010-12-13 18:01 ` [PATCH 7/9] xen-pciback: Backend driver for Xen pci-front Konrad Rzeszutek Wilk
2010-12-13 18:01 ` [PATCH 8/9] xen/pciback: Fix checkpatch warnings and errors Konrad Rzeszutek Wilk
2010-12-13 18:01 ` [PATCH 9/9] xen/xen-pciback: Swap over to DEFINE_PCI_DEVICE_TABLE Konrad Rzeszutek Wilk
2010-12-14 10:08 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0750250200007800027C67@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=konrad@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).