From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@novell.com>
Subject: Re: [PATCH 9/9] xen/xen-pciback: Swap over to
	DEFINE_PCI_DEVICE_TABLE
Date: Tue, 14 Dec 2010 10:08:21 +0000
Message-ID: <4D0750250200007800027C67@vpn.id2.novell.com>
References: <1292263303-31680-1-git-send-email-konrad.wilk@oracle.com>
	<1292263303-31680-10-git-send-email-konrad.wilk@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1292263303-31680-10-git-send-email-konrad.wilk@oracle.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Konrad Rzeszutek Wilk <konrad@kernel.org>, Jeremy Fitzhardinge <jeremy@goop.org>, linux-kernel@vger.kernel.org, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

>>> On 13.12.10 at 19:01, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> =
wrote:
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
>  drivers/xen/pciback/pci_stub.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/drivers/xen/pciback/pci_stub.c b/drivers/xen/pciback/pci_stu=
b.c
> index c8f6f29..09dd60c 100644
> --- a/drivers/xen/pciback/pci_stub.c
> +++ b/drivers/xen/pciback/pci_stub.c
> @@ -497,7 +497,7 @@ static void pcistub_remove(struct pci_dev *dev)
>  	}
>  }
> =20
> -static const struct pci_device_id pcistub_ids[] =3D {
> +DEFINE_PCI_DEVICE_TABLE(pcistub_ids) =3D {
>  	{
>  	 .vendor =3D PCI_ANY_ID,
>  	 .device =3D PCI_ANY_ID,


You shouldn't drop "static" here.

Jan