From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH] Re-define PKT_PROT_LEN to be bigger. Date: Tue, 14 Dec 2010 14:17:13 -0800 Message-ID: <4D07ECE9.9090600@goop.org> References: <1292358922-5569-1-git-send-email-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1292358922-5569-1-git-send-email-paul.durrant@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Paul Durrant Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 12/14/2010 12:35 PM, Paul Durrant wrote: > Re-define PKT_PROT_LEN to be big enough to handle maximal IPv4 and TCP options and phrase > the definition so that it's reasonably obvious that's what it's for. Which kernel are these for? Thanks, J > Signed-off-by: Paul Durrant > --- > drivers/xen/netback/netback.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/xen/netback/netback.c b/drivers/xen/netback/netback.c > index c448675..1a4a20e 100644 > --- a/drivers/xen/netback/netback.c > +++ b/drivers/xen/netback/netback.c > @@ -128,7 +128,7 @@ static inline int netif_get_page_ext(struct page *pg, unsigned int *_group, unsi > * packet processing on them (netfilter, routing, etc). 72 is enough > * to cover TCP+IP headers including options. > */ > -#define PKT_PROT_LEN 72 > +#define PKT_PROT_LEN (ETH_HLEN + 4 + (15 * 4) + (15 * 4)) > > static inline pending_ring_idx_t pending_index(unsigned i) > {