From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@novell.com>
Subject: Re: [PATCH] Enble 6 argument hypercalls for HVMs
Date: Wed, 15 Dec 2010 12:12:01 +0000
Message-ID: <4D08BEA102000078000281FE@vpn.id2.novell.com>
References: <4D08A920020000780002811F@vpn.id2.novell.com>
	<C92E5A71.2907C%keir@xen.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C92E5A71.2907C%keir@xen.org>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir@xen.org>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

>>> On 15.12.10 at 12:43, Keir Fraser <keir@xen.org> wrote:
> On 15/12/2010 10:40, "Jan Beulich" <JBeulich@novell.com> wrote:
>> Looking at this code also makes me wonder once again whether
>> it really is a good idea to have a generally not taken forward
>> branch here.
>=20
> Which generally not-taken branch? The 'je 1f' instruction generally =
*will*
> be taken!

Oops, of course - it being taken is the problem, as it'll be statically
mis-predicted.

Jan