From: "Jan Beulich" <JBeulich@novell.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] x86/32on64: zero-extend hypercall index before use in memory access (debug mode only)
Date: Thu, 16 Dec 2010 08:04:39 +0000 [thread overview]
Message-ID: <4D09D6270200007800028503@vpn.id2.novell.com> (raw)
In-Reply-To: <4D093F57.7030809@goop.org>
>>> On 15.12.10 at 23:21, Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> On 12/15/2010 02:50 AM, Jan Beulich wrote:
>> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>>
>> --- a/xen/arch/x86/x86_64/compat/entry.S
>> +++ b/xen/arch/x86/x86_64/compat/entry.S
>> @@ -25,7 +25,8 @@ ENTRY(compat_hypercall)
>> pushq UREGS_rbx(%rsp); pushq %rcx; pushq %rdx; pushq %rsi; pushq
> %rdi
>> pushq UREGS_rbp+5*8(%rsp)
>> leaq compat_hypercall_args_table(%rip),%r10
>> - movq $6,%rcx
>> + movl %eax,%eax
>> + movl $6,%ecx
>
> Is the second line part of the fix, or just a drive-by tweak?
The latter (sorry, I couldn't withstand, as I was surprised I
didn't do so when I created this code as a clone of its native
counterpart).
Jan
prev parent reply other threads:[~2010-12-16 8:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 10:50 [PATCH] x86/32on64: zero-extend hypercall index before use in memory access (debug mode only) Jan Beulich
2010-12-15 22:21 ` Jeremy Fitzhardinge
2010-12-16 8:04 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D09D6270200007800028503@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=jeremy@goop.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).