xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: ZhouPeng <zpengxen@gmail.com>
Cc: "Xen-Devel (E-mail)" <xen-devel@lists.xensource.com>,
	keir.fraser@eu.citrix.com
Subject: Re: Re: Panic on cpu0
Date: Thu, 16 Dec 2010 11:47:59 +0000	[thread overview]
Message-ID: <4D0A0A7F0200007800028595@vpn.id2.novell.com> (raw)
In-Reply-To: <AANLkTi=mLQzJkJ08DxMHDXWrLxyH++BymrTNPP-F9zba@mail.gmail.com>

>>> On 16.12.10 at 10:30, ZhouPeng <zpengxen@gmail.com> wrote:
> The err msg appears in
> void *map_domain_page(unsigned long mfn)
>       BUG_ON(idx >= MAPCACHE_ENTRIES);
> 
> printk idx is 1024 and BUG_ON is called.
> 
> I print  Xen call trace msg:
> 
> [<ffcd3c2>]  map_domain_page+0x1a2/0x230
> [<ff1cd718>] unmap_domain_page+0x148/0x160
>                    addr_to_dma_page_maddr+0x1f6/0x250
>                    __find_next_zero_bit+0x80/0x90
>                    intel_iommu_map_page+0x14a/0x250
>                    domain_context_mapping+0x14a/0x250
>                    rmrr_identity_mapping+0xb7/0x120
>                    intel_iommu_dom0_init+0x143/0x1eb
>                    construct_dom0+0x138f/0x16b0
>                    __start_xen+0x109a/0x1680
>                    e820nf+0x0/0x4
>                    __high_start+0x58/0x5a

Could you give the below patch a try?

Jan

--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -1331,6 +1331,7 @@ int domain_context_mapping_one(
     if ( context_set_domain_id(context, domain, iommu) )
     {
         spin_unlock(&iommu->lock);
+        unmap_vtd_domain_page(context_entries);
         return -EFAULT;
     }
 
@@ -1672,6 +1673,7 @@ static int intel_iommu_map_page(
     if ( old.val == new.val )
     {
         spin_unlock(&hd->mapping_lock);
+        unmap_vtd_domain_page(page);
         return 0;
     }
     *pte = new;

  parent reply	other threads:[~2010-12-16 11:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-16  6:40 Panic on cpu0 ZhouPeng
2010-12-16  7:41 ` ZhouPeng
2010-12-16  7:59   ` Pasi Kärkkäinen
2010-12-16  9:30     ` ZhouPeng
2010-12-16  9:41       ` ZhouPeng
2010-12-16 10:36         ` Keir Fraser
2010-12-16 11:24           ` ZhouPeng
2010-12-16 11:43             ` Pasi Kärkkäinen
2010-12-16 15:25               ` ZhouPeng
2010-12-16 15:34                 ` Pasi Kärkkäinen
2010-12-16 15:46                   ` Jan Beulich
2011-01-05 13:37                     ` Stefano Stabellini
2011-01-05 13:57                       ` Ian Campbell
2011-01-07  7:24                         ` ZhouPeng
2011-01-07  9:00                           ` Ian Campbell
2011-01-07  9:24                             ` Pasi Kärkkäinen
2010-12-16 11:47             ` Keir Fraser
2010-12-16 11:52               ` Pasi Kärkkäinen
2010-12-16 15:20               ` ZhouPeng
2010-12-16 11:47       ` Jan Beulich [this message]
2010-12-16 15:18         ` ZhouPeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D0A0A7F0200007800028595@vpn.id2.novell.com \
    --to=jbeulich@novell.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=zpengxen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).