From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: [PATCH] xend: drbd improvements Date: Thu, 16 Dec 2010 17:45:12 -0700 Message-ID: <4D0AB298.4080202@novell.com> References: <19673.37479.133902.499115@mariner.uk.xensource.com> <4CD9C962.4030701@novell.com> <4CDADB46.7020100@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4CDADB46.7020100@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: xen-devel@lists.xensource.com, Berthold Gunreben List-Id: xen-devel@lists.xenproject.org Jim Fehlig wrote: > Jim Fehlig wrote: > >> Ian Jackson wrote: >> >> >>> Jim Fehlig writes ("[Xen-devel] [PATCH] xend: drbd improvements"): >>> >>> >>> >>>> xend: drbd improvements >>>> >>>> 1) drbdadm state is debrecated, and the script tries to detect the >>>> primary/secondary information from the deprecated message >>>> 2) os.popen2 does not work with the array as argument >>>> 3) popen2 is deprecated since python2.6 >>>> >>>> >>>> >>> Forgive my ignorance, but: why does xend need to mess with drbd at >>> all ? Why can't it just open the block device ? >>> >>> >>> >> Good question. I too was surprised to see special casing of drbd within >> xend. Seems c/s 20158 added this code to allow bootloaders (pygrub, >> domUloader, et. al.) to work with drbd devices using the 'drbd:resource' >> syntax. Perhaps the author of that patch (cc'd) can provide more >> details. >> > > The patch author's mail address is no longer valid, so we won't be > receiving any feedback from him :-(. > Sorry for the delay here, but I finally got around to investigating this further. As it turns out, drbd's block-drbd script handles all of the details that c/s 20158 introduces within xend :-(. IMO, this c/s should be reverted as it causes a regression. I've tested drbd without this changeset and it works fine. Regards, Jim