From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Nenciarini Subject: Re: XFS support for pygrub patch Date: Thu, 23 Dec 2010 16:27:30 +0100 Message-ID: <4D136A62.4070905@devise.it> References: <4CEF9700.4090706@devise.it> <4D07EE72.3060406@devise.it> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4D07EE72.3060406@devise.it> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Stefano Stabellini Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 14/12/2010 23:23, Marco Nenciarini wrote: > On 13/12/2010 18:06, Stefano Stabellini wrote: >> On Fri, 26 Nov 2010, Marco Nenciarini wrote: >>> >>> Hi, >>> I've ported the xfs code from grub to pygrub for our company internal= use. >>> >>> If you find it useful fell free to merge with main code. >> >> Can anybody test this patch and confirm it works properly? >=20 > To help you testing the patch and auditing the code, I've attached to > this message the diff against xfs code in grub-0.97. >=20 > As stated before, the resulting fsimage.so works perfectly for me when > installed in XCP-0.5 as /usr/lib/fs/xfs/fsimage.so >=20 > Actually I've 3 Debian Squeeze machines and one Ubuntu 10.10 machine in > our testing environment booting from xfs with pygrub. >=20 > The only problem I've found is that the module doesn't compile on Debia= n > based system due to some bug in gcc code optimizer. On such a systems > the compiler returns the following error: >=20 > gcc -DPIC -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=3Dgn= u99 > -Wall -Wstrict-prototypes -Wno-unused-value > -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .fsys_xfs.opic.= d > -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE > -I../../../tools/libfsimage/common/ -Werror -fPIC -c -o fsys_xfs.opic > fsys_xfs.c > fsys_xfs.c: In function =91next_dentry=92: > fsys_xfs.c:409: error: extended registers have no high halves > fsys_xfs.c:409: error: extended registers have no high halves >=20 > The problem disappear if you turn off optimization with -O0 >=20 I've solved the compilation error on Ubuntu/Debian x86_64 (sed s/"=3Dq"/"=3DQ"/), but the resulting libary doesn't works (it doesn't eve= n recognize the XFS partition). I'll debug it during the next week. Regards, Marco --=20 Marco Nenciarini - System manager @ Devise.IT marco.nenciarini@devise.it | http://www.devise.it