From: "Jan Beulich" <JBeulich@novell.com>
To: Samuel Kvasnica <bugreports@list.ims.co.at>
Cc: kama@jp.fujitsu.com, t.horikoshi@jp.fujitsu.com,
xen-devel@lists.xensource.com
Subject: Re: vscsi 2TB patches
Date: Tue, 04 Jan 2011 13:07:54 +0000 [thread overview]
Message-ID: <4D2329BA020000780002A32F@vpn.id2.novell.com> (raw)
In-Reply-To: <4D231AA0.8060500@list.ims.co.at>
>>> On 04.01.11 at 14:03, Samuel Kvasnica <bugreports@list.ims.co.at> wrote:
> On 01/04/2011 12:47 PM, Jan Beulich wrote:
>>>>> On 04.01.11 at 12:24, Samuel Kvasnica <bugreports@list.ims.co.at> wrote:
>>> Ok, I'm attaching the changed patch, hope the format is correct now.
>> I notice that compared to your first mail, at least scsifront has more
>> changes now - how is that explained?
>>
>> Jan
>>
> Yeh, sorry for that, theres one extra debug printk included now, which
> is commented out.
> However, this can be very handy in future, if somebody looks for more
> missing
> scsi commands, so maybe it could remain there ?
I wasn't actually after the printk(), but rather noticing your original
scsifront patch apparently consisted of only an added comment;
that I was wrong with actually (not being used to read non-unified
diffs), but your newer patch still contains a number of apparently
arbitrary newline insertions and removals.
Jan
next prev parent reply other threads:[~2011-01-04 13:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 20:11 vscsi 2TB patches Samuel Kvasnica
2011-01-03 23:06 ` Pasi Kärkkäinen
2011-01-04 11:24 ` Samuel Kvasnica
2011-01-04 11:44 ` Jan Beulich
[not found] ` <4D231A46.2000209@list.ims.co.at>
[not found] ` <4D232ADB020000780002A33B@vpn.id2.novell.com>
[not found] ` <4D2321DE.9030706@list.ims.co.at>
[not found] ` <4D233968020000780002A36E@vpn.id2.novell.com>
2011-01-04 14:46 ` Samuel Kvasnica
2011-01-04 14:55 ` Jan Beulich
2011-01-04 11:47 ` Jan Beulich
2011-01-04 13:03 ` Samuel Kvasnica
2011-01-04 13:07 ` Jan Beulich [this message]
2011-01-04 13:23 ` Samuel Kvasnica
2011-01-04 14:06 ` Jan Beulich
2011-01-11 16:26 ` Jan Beulich
2011-01-18 11:45 ` Jan Beulich
2011-01-24 12:24 ` Samuel Kvasnica
2011-01-04 9:47 ` Jan Beulich
2011-01-04 12:57 ` Samuel Kvasnica
2011-01-04 13:01 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2329BA020000780002A32F@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=bugreports@list.ims.co.at \
--cc=kama@jp.fujitsu.com \
--cc=t.horikoshi@jp.fujitsu.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).