From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: vscsi 2TB patches Date: Tue, 04 Jan 2011 13:07:54 +0000 Message-ID: <4D2329BA020000780002A32F@vpn.id2.novell.com> References: <4D222D71.9020508@list.ims.co.at><20110103230621.GP2754@reaktio.net><4D230357.3070604@list.ims.co.at><4D2316D5020000780002A2F1@vpn.id2.novell.com> <4D231AA0.8060500@list.ims.co.at> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4D231AA0.8060500@list.ims.co.at> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Samuel Kvasnica Cc: kama@jp.fujitsu.com, t.horikoshi@jp.fujitsu.com, xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> On 04.01.11 at 14:03, Samuel Kvasnica = wrote: > On 01/04/2011 12:47 PM, Jan Beulich wrote: >>>>> On 04.01.11 at 12:24, Samuel Kvasnica = wrote: >>> Ok, I'm attaching the changed patch, hope the format is correct now. >> I notice that compared to your first mail, at least scsifront has more >> changes now - how is that explained? >> >> Jan >> > Yeh, sorry for that, theres one extra debug printk included now, which > is commented out. > However, this can be very handy in future, if somebody looks for more > missing > scsi commands, so maybe it could remain there ? I wasn't actually after the printk(), but rather noticing your original scsifront patch apparently consisted of only an added comment; that I was wrong with actually (not being used to read non-unified diffs), but your newer patch still contains a number of apparently arbitrary newline insertions and removals. Jan