Re: [PATCH] pvops: fix "xm save -c" issue

[Kenji Wakamiya <wkenji@jp.fujitsu.com>]

Hi Konrand, and sorry for very late response.

(2011/01/11 2:01), Konrad Rzeszutek Wilk wrote:
>> With this change how is the effect of dpm_suspend_start undone in the
>> suspend cancelled case?
>>
>> Currently we have
>> 	dpm_suspend_start(PMSG_SUSPEND)
>> 	 xs_suspend
>> 	   dpm_suspend_noirq(PMSG_SUSPEND)
>> 	      SUSPEND
>> 	   dpm_resume_noirq(PMSG_RESUME)
>> 	 xs_resume or xs_supend_cancel
>> 	dpm_resume_end(PMSG_RESUME)
>>
>> Which seems nicely nested and logical but by only calling dpm_resume_end
>> in the non-cancelled case we seem to be unbalancing things.
>>
>> Do we need some sort of dpm_resume_cancel, or some way of pushing the
>> cancelled flag down into the individual xenbus_device.resume handlers?
>>
>> Should we maybe simply be using a difference PMSG_XXX in the cancelled
>> case? Is this what one of PMSG_RESTORE or PMSG_RECOVER means?
>>
>> Looks like to propagate the PMSG_* to the actual device resume functions
>> we would need to provide a pm_ops for the struct bus xenbus_frontend
>> instead of relying on the legacy handlers. This is probably a
>> independently good idea anyway.
>
> ping?
>
> Kenji any ideas or patches to address Ian's comments?

My colleague made a patch which reflected Ian's comments, so I will ask 
him to post it. Please wait a little.

Thanks,
Kenji