From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenji Wakamiya Subject: Re: [PATCH] pvops: fix "xm save -c" issue Date: Fri, 21 Jan 2011 14:35:09 +0900 Message-ID: <4D391B0D.8010708@jp.fujitsu.com> References: <4D070138.7090708@jp.fujitsu.com> <20101214145925.GA5769@dumpdata.com> <4D08417E.7060104@jp.fujitsu.com> <20101215154021.GB28984@dumpdata.com> <4D09A882.5070504@jp.fujitsu.com> <1292578996.32368.11510.camel@zakaz.uk.xensource.com> <20110110170141.GA29764@dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110110170141.GA29764@dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Konrad Rzeszutek Wilk Cc: "xen-devel@lists.xensource.com" , Ian Campbell List-Id: xen-devel@lists.xenproject.org Hi Konrand, and sorry for very late response. (2011/01/11 2:01), Konrad Rzeszutek Wilk wrote: >> With this change how is the effect of dpm_suspend_start undone in the >> suspend cancelled case? >> >> Currently we have >> dpm_suspend_start(PMSG_SUSPEND) >> xs_suspend >> dpm_suspend_noirq(PMSG_SUSPEND) >> SUSPEND >> dpm_resume_noirq(PMSG_RESUME) >> xs_resume or xs_supend_cancel >> dpm_resume_end(PMSG_RESUME) >> >> Which seems nicely nested and logical but by only calling dpm_resume_end >> in the non-cancelled case we seem to be unbalancing things. >> >> Do we need some sort of dpm_resume_cancel, or some way of pushing the >> cancelled flag down into the individual xenbus_device.resume handlers? >> >> Should we maybe simply be using a difference PMSG_XXX in the cancelled >> case? Is this what one of PMSG_RESTORE or PMSG_RECOVER means? >> >> Looks like to propagate the PMSG_* to the actual device resume functions >> we would need to provide a pm_ops for the struct bus xenbus_frontend >> instead of relying on the legacy handlers. This is probably a >> independently good idea anyway. > > ping? > > Kenji any ideas or patches to address Ian's comments? My colleague made a patch which reflected Ian's comments, so I will ask him to post it. Please wait a little. Thanks, Kenji