From mboxrd@z Thu Jan  1 00:00:00 1970
From: Juergen Gross <juergen.gross@ts.fujitsu.com>
Subject: Re: [PATCH]: xl: fix broken cpupool-numa-split
Date: Fri, 28 Jan 2011 12:01:52 +0100
Message-ID: <4D42A220.4030908@ts.fujitsu.com>
References: <4D41E547.5000902@amd.com>	<4D426189.1030001@ts.fujitsu.com>
	<AANLkTi=bM36G-+VMCQA6zvbXxdH_z-hdqX7kxRv1XBY5@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <AANLkTi=bM36G-+VMCQA6zvbXxdH_z-hdqX7kxRv1XBY5@mail.gmail.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Andre Przywara <andre.przywara@amd.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 01/28/11 11:53, George Dunlap wrote:
> On Fri, Jan 28, 2011 at 6:26 AM, Juergen Gross
> <juergen.gross@ts.fujitsu.com>  wrote:
>> On 01/27/11 22:36, Andre Przywara wrote:
>>>
>>> Hi,
>>>
>>> the implementation of xl cpupool-numa-split is broken. It basically
>>> deals with only one poolid, but there are two to consider: the one from
>>> the original root CPUpool, the other from the newly created one.
>>
>> Uhh, silly copy and paste error! I think it happened when I introduced
>> libxl_cpupool_cpuadd_node()...
>> The correction is much easier. The root poolid is always 0. See attached
>> patch.
>
> Re patch itself: Acked-by: George Dunlap<george.dunlap@citrix.com>
>
> Re the cpupool interface:
>
> Hang on; if the root poolid is always 0, why does xc_cpupool_create()
> interpret a poolid of 0 as "XEN_SYSCTL_CPUPOOL_PAR_ANY"?  Doesn't that
> mean that if you're trying to create a new cpupool from cpus in the
> root pool, that you might get cpus from other pools?

No. It just creates a cpupool. As cpupool 0 is always created by the
hypervisor, it can't be created via libxc. So specifying 0 as poolid
selects the next free id.

The cpus are allocated later.

>
> If not, what's the point of the "CPUPOOL_PAR_ANY" parsing?

Perhaps you just don't care which poolid you get?


Juergen

-- 
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html