xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: Haitao Shan <maillists.shan@gmail.com>, Keir Fraser <keir@xen.org>
Cc: Yunhong Jiang <yunhong.jiang@intel.com>, xen-devel@lists.xensource.com
Subject: Re: Comments on Xen bug 1732
Date: Mon, 31 Jan 2011 13:00:20 +0000	[thread overview]
Message-ID: <4D46C074020000780002F73E@vpn.id2.novell.com> (raw)
In-Reply-To: <AANLkTi=-q=L1Q1gcHzY_6GWjqbpoP7-Y5sSFbky2h3KC@mail.gmail.com>

>>> On 31.01.11 at 13:02, Haitao Shan <maillists.shan@gmail.com> wrote:
> I am wondering whether we can trust msi->table_base for the moment?

But that's already the case. A warning is issued if it doesn't match
what we read from the BAR, but what comes from Dom0 is being
used. The PBA, which doesn't gets passed up from Dom0, gets
determined by reading the device's config space (and is going to
be zero or close to it when the BAR is blank). Xen itself doesn't
use it for anything but trying to write-protect the corresponding
MFN.

> Simply removing the warnings can of course suppress the symptom. But
> assuming MSIX table at pfn 0 and changing its p2m type are a concern to me.
> But probably this won't trigger anything bad, since this pfn is seldom used?

We should not use MFN zero here (and that really is what I
intended the warnings to catch).

Jan

  reply	other threads:[~2011-01-31 13:00 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-31  4:54 Comments on Xen bug 1732 Haitao Shan
2011-01-31  8:23 ` Jan Beulich
2011-01-31  8:29   ` Jiang, Yunhong
2011-01-31  8:52   ` Haitao Shan
2011-01-31  9:02     ` Haitao Shan
2011-01-31 10:59       ` Keir Fraser
2011-01-31 12:02         ` Haitao Shan
2011-01-31 13:00           ` Jan Beulich [this message]
2011-01-31 14:54       ` Stefano Stabellini
2011-01-31  9:16     ` Jan Beulich
2011-01-31 13:18 ` Jan Beulich
2011-02-01  5:48   ` Haitao Shan
2011-02-01  8:05     ` Jan Beulich
2011-02-11  6:00       ` Haitao Shan
2011-02-11  8:58         ` Jan Beulich
2011-02-11 10:34           ` Li, Xin
2011-03-15 18:30   ` Gianni Tedesco
2011-03-16  8:22     ` Jan Beulich
2011-03-16 13:50       ` Gianni Tedesco
2011-03-17  7:48         ` Jan Beulich
2011-03-17 16:42           ` Gianni Tedesco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D46C074020000780002F73E@vpn.id2.novell.com \
    --to=jbeulich@novell.com \
    --cc=keir@xen.org \
    --cc=maillists.shan@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=yunhong.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).