From: Laszlo Ersek <lersek@redhat.com>
To: Daniel Stodden <daniel.stodden@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Jan Beulich <JBeulich@novell.com>
Subject: Re: [PATCH linux-2.6.18-xen] blktap: make max # of tap devices a module parameter
Date: Tue, 22 Feb 2011 19:08:11 +0100 [thread overview]
Message-ID: <4D63FB8B.6010309@redhat.com> (raw)
In-Reply-To: <1298396687.27394.10.camel@agari.van.xensource.com>
On 02/22/11 18:44, Daniel Stodden wrote:
> I'm pretty sure minors> 256 date way before 2.6.32. Here's the module
> init fragment from blktap2, replacing the register_chrdev() call:
>
> [...]
That's about what I was thinking of in [0]. It also sets the cdev's owner manually. However, register_chrdev() also does this:
225 kobject_set_name(&cdev->kobj, "%s", name);
226 for (s = strchr(kobject_name(&cdev->kobj),'/'); s; s = strchr(s, '/'))
227 *s = '!';
I reckon we can ignore the 's,/,!,g' replacement, since the name is fixed "blktap" (or "blktap2"). But the kobject name doesn't appear to be set in the first place. Is that no problem? If not, I'd just omit it from blktap as well.
Thank you!
lacos
[0] https://bugzilla.redhat.com/show_bug.cgi?id=452650#c21
next prev parent reply other threads:[~2011-02-22 18:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 14:20 [PATCH linux-2.6.18-xen] blktap: make max # of tap devices a module parameter Laszlo Ersek
2011-02-22 15:49 ` Jan Beulich
2011-02-22 17:34 ` Laszlo Ersek
2011-02-22 17:44 ` Daniel Stodden
2011-02-22 18:08 ` Laszlo Ersek [this message]
2011-02-22 18:59 ` Daniel Stodden
2011-02-23 10:38 ` Jan Beulich
2011-02-24 16:40 ` Jan Beulich
2011-02-24 19:59 ` Daniel Stodden
2011-02-24 20:10 ` Daniel Stodden
2011-02-23 9:42 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D63FB8B.6010309@redhat.com \
--to=lersek@redhat.com \
--cc=JBeulich@novell.com \
--cc=daniel.stodden@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).