From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laszlo Ersek Subject: Re: [PATCH linux-2.6.18-xen] blktap: make max # of tap devices a module parameter Date: Tue, 22 Feb 2011 19:08:11 +0100 Message-ID: <4D63FB8B.6010309@redhat.com> References: <4D63C644.1000503@redhat.com> <4D63E918020000780003327C@vpn.id2.novell.com> <4D63F3B7.90108@redhat.com> <1298396687.27394.10.camel@agari.van.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1298396687.27394.10.camel@agari.van.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Daniel Stodden Cc: "xen-devel@lists.xensource.com" , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 02/22/11 18:44, Daniel Stodden wrote: > I'm pretty sure minors> 256 date way before 2.6.32. Here's the module > init fragment from blktap2, replacing the register_chrdev() call: > > [...] That's about what I was thinking of in [0]. It also sets the cdev's owner manually. However, register_chrdev() also does this: 225 kobject_set_name(&cdev->kobj, "%s", name); 226 for (s = strchr(kobject_name(&cdev->kobj),'/'); s; s = strchr(s, '/')) 227 *s = '!'; I reckon we can ignore the 's,/,!,g' replacement, since the name is fixed "blktap" (or "blktap2"). But the kobject name doesn't appear to be set in the first place. Is that no problem? If not, I'd just omit it from blktap as well. Thank you! lacos [0] https://bugzilla.redhat.com/show_bug.cgi?id=452650#c21