From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@novell.com>
Subject: Re: [PATCH] Fix cpu offline bug
Date: Tue, 08 Mar 2011 08:52:23 +0000
Message-ID: <4D75FC5702000078000351B2@vpn.id2.novell.com>
References: <BC00F5384FCFC9499AF06F92E8B78A9E1FA4F5A806@shsmsx502.ccr.corp.intel.com>
	<C9967421.14234%keir.xen@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C9967421.14234%keir.xen@gmail.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.xen@gmail.com>
Cc: Jinsong Liu <jinsong.liu@intel.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Yunhong Jiang <yunhong.jiang@intel.com>, Xin Li <xin.li@intel.com>
List-Id: xen-devel@lists.xenproject.org

>>> On 05.03.11, Keir Fraser <keir.xen@gmail.com> wrote:
>Urk, good point!

But your fix still allows what the comment says it is supposed to avoid
- simply introducing a variable doesn't help afaict, you also need to
insert a barrier() to avoid a second read (or "cpu_state" would need
to be volatile).

Jan