From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@novell.com>
Subject: Re: [PATCH 2 of 8] x86: add explicit size suffixes
	to some assembly instructions
Date: Tue, 08 Mar 2011 09:27:07 +0000
Message-ID: <4D76047B02000078000351C9@vpn.id2.novell.com>
References: <patchbomb.1299497177@whitby.uk.xensource.com>
	<b7eaf2bcdca1307bf4ec.1299497179@whitby.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <b7eaf2bcdca1307bf4ec.1299497179@whitby.uk.xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Tim Deegan <Tim.Deegan@citrix.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

>>> On 07.03.11 at 12:26, Tim Deegan <Tim.Deegan@citrix.com> wrote:
>--- a/xen/arch/x86/x86_emulate/x86_emulate.c	Mon Mar 07 11:21:11 2011 =
+0000
>+++ b/xen/arch/x86/x86_emulate/x86_emulate.c	Mon Mar 07 11:21:11 2011 =
+0000
>@@ -2678,7 +2678,7 @@ x86_emulate(
>                 emulate_fpu_insn_memsrc("fiaddl", src.val);
>                 break;
>             case 1: /* fimul m64i */
>-                emulate_fpu_insn_memsrc("fimul", src.val);
>+                emulate_fpu_insn_memsrc("fimuls", src.val);

fimull.

>                 break;
>             case 2: /* ficom m64i */
>                 emulate_fpu_insn_memsrc("ficoml", src.val);

(Side note: The comments in this section are all wrong - they
should say "m32i"; there are no 64-bit integer operations
other than loads and stores.)

Jan