From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@novell.com>
Subject: bogus check in get_page_from_l1e()?
Date: Tue, 08 Mar 2011 11:07:41 +0000
Message-ID: <4D761C0D0200007800035236@vpn.id2.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir@xen.org>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Keir,

in the I/O page code path, we have

        if ( !iomem_access_permitted(pg_owner, mfn, mfn) )
        {
            if ( mfn !=3D (PADDR_MASK >> PAGE_SHIFT) ) /* INVALID_MFN? */
                MEM_LOG("Non-privileged (%u) attempt to map I/O space =
%08lx",=20
                        pg_owner->domain_id, mfn);
            return 0;
        }

What is the reason to suppress the warning for the one specific
(PADDR_MASK >> PAGE_SHIFT) MFN value, i.e. where could this
validly come from and hence warrant not to issue the warning?

Also, the message seems to be having the potential of being
misleading (these days at least, but perhaps it always was), as
it clearly is possible for Dom0 to also be denied a mapping here
(and hence the "Non-privileged" can be wrong).

Bottom line question: Should we issue the warning unconditionally,
just stating the domain ID?

Thanks, Jan