From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH 0/5] x86: properly propagate errors to hypercall callee Date: Tue, 15 Mar 2011 12:29:07 +0000 Message-ID: <4D7F69A30200007800036914@vpn.id2.novell.com> References: <4D776A320200007800035752@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4D776A320200007800035752@vpn.id2.novell.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org >>> On 09.03.11 at 11:53, "Jan Beulich" wrote: > 1: don't BUG() post-boot in alloc_xen_pagetable() > 2: run-time callers of map_pages_to_xen() must check for errors I actually think that the first two should be considered for 4.0 and 4.1, as those are preventing a guest induced host crash. The other three are more of enhancement type (propagating a meaningful error to the calling guest). Jan > 3: make get_page_from_l1e() return a proper error code > 4: make mod_l1_entry() return a proper error code > 5: make mod_l2_entry() return a proper error code >=20 > All but the last are clear candidates for backporting to 4.1 and 4.0, > albeit for the former perhaps only after 4.1.0. >=20 > Signed-off-by: Jan Beulich