From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: xen-unstable: build fails Date: Thu, 17 Mar 2011 11:29:04 +0100 Message-ID: <4D81E270.9000100@ts.fujitsu.com> References: <4D81CD8A.9050601@ts.fujitsu.com> <4D81ECC1020000780003705D@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4D81ECC1020000780003705D@vpn.id2.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: Keir Fraser , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 03/17/11 11:13, Jan Beulich wrote: >>>> On 17.03.11 at 09:59, Juergen Gross wrote: >> The problem is still the relative XEN_ROOT specification. >> Or the missing .config under XEN_ROOT, so creating this file solves my >> problem. :-) > > I'd favor the latter, e.g. by adding something like > > cfg-create := $(shell touch $(XEN_ROOT)/.config) > > to ./Config.mk, or putting the include in a conditional instead > of making use of -include. As short time measure this seems to be okay. On the long run I'd prefer to use absolute paths only. Otherwise you've always a risk to use something from outside the intended build environment. XEN_ROOT = $(abspath ../..) seems not too hard to use instead of XEN_ROOT = ../.. And I'm still favoring usage of conditional setting of XEN_ROOT in included Makefiles other than config/* to avoid hard to find problems. Juergen -- Juergen Gross Principal Developer Operating Systems TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com Domagkstr. 28 Internet: ts.fujitsu.com D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html