From: "Jan Beulich" <JBeulich@novell.com>
To: xen-devel@lists.xensource.com
Cc: ian.jackson@eu.citrix.com
Subject: Re: [xen-unstable test] 6532: regressions - trouble: broken/fail/pass
Date: Thu, 17 Mar 2011 10:43:40 +0000 [thread overview]
Message-ID: <4D81F3EC02000078000370B0@vpn.id2.novell.com> (raw)
In-Reply-To: <4D81F13B020000780003708F@vpn.id2.novell.com>
>>> On 17.03.11 at 11:32, "Jan Beulich" <JBeulich@novell.com> wrote:
>>>> On 16.03.11 at 22:58, xen.org <ian.jackson@eu.citrix.com> wrote:
>> flight 6532 xen-unstable real [real]
>> http://www.chiark.greenend.org.uk/~xensrcts/logs/6532/
>>
>> Regressions :-(
>>
>> Tests which did not succeed and are blocking:
>> test-amd64-amd64-pv 5 xen-boot fail REGR. vs. 6396
>
> Seems like this is still failing at the same place in hpet.c, despite
> 23042:599ceb5b0a9b. Is the corresponding xen-syms available
> somewhere so I can sort out the condition to (hopefully) get a
> hint at what's still wrong?
Oh, no, I see what's wrong: That c/s only adjusts a variable local
to hpet_fsb_cap_lookup(), but num_hpets_used gets set to
non-zero only once hpet_fsb_cap_lookup() returns. I think the
local variable should go away altogether, as it being non-zero
(no matter how large) will in any case mean the legacy code path
won't be used.
I'll send another fixup patch shortly.
Jan
next prev parent reply other threads:[~2011-03-17 10:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 21:58 [xen-unstable test] 6532: regressions - trouble: broken/fail/pass xen.org
2011-03-17 10:32 ` Jan Beulich
2011-03-17 10:43 ` Jan Beulich [this message]
2011-03-17 19:47 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D81F3EC02000078000370B0@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).