From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [xen-unstable test] 6532: regressions - trouble: broken/fail/pass Date: Thu, 17 Mar 2011 10:43:40 +0000 Message-ID: <4D81F3EC02000078000370B0@vpn.id2.novell.com> References: <4D81F13B020000780003708F@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4D81F13B020000780003708F@vpn.id2.novell.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org >>> On 17.03.11 at 11:32, "Jan Beulich" wrote: >>>> On 16.03.11 at 22:58, xen.org wrote: >> flight 6532 xen-unstable real [real] >> http://www.chiark.greenend.org.uk/~xensrcts/logs/6532/=20 >>=20 >> Regressions :-( >>=20 >> Tests which did not succeed and are blocking: >> test-amd64-amd64-pv 5 xen-boot fail REGR. = vs. 6396 >=20 > Seems like this is still failing at the same place in hpet.c, despite > 23042:599ceb5b0a9b. Is the corresponding xen-syms available > somewhere so I can sort out the condition to (hopefully) get a > hint at what's still wrong? Oh, no, I see what's wrong: That c/s only adjusts a variable local to hpet_fsb_cap_lookup(), but num_hpets_used gets set to non-zero only once hpet_fsb_cap_lookup() returns. I think the local variable should go away altogether, as it being non-zero (no matter how large) will in any case mean the legacy code path won't be used. I'll send another fixup patch shortly. Jan