From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: credit2's csched_init() registering of a CPU notifier Date: Fri, 18 Mar 2011 09:24:33 +0000 Message-ID: <4D8332E10200007800037367@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: George Dunlap Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org George, as ->init() can be called more than once (for CPU pools) it seems wrong to do any global initialization in ->init(). The question is whether it's worth adding a ->global_init(), or whether instead a callout from the notifier schedule.c sets up wouldn't be a better mechanism (though that would require maintaining a list of scheduler instances). Jan