From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@novell.com>
Subject: Re: [PATCH 5 of 5] xentrace: use consistent printk prefix
Date: Wed, 23 Mar 2011 10:14:11 +0000
Message-ID: <4D89D6030200007800037DC1@vpn.id2.novell.com>
References: <patchbomb.1300821688@localhost>
	<dcbae547cce81f10c243.1300821693@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <dcbae547cce81f10c243.1300821693@localhost>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Olaf Hering <olaf@aepfle.de>
Cc: xen-devel@lists.xensource.com, George Dunlap <george.dunlap@citrix.com>
List-Id: xen-devel@lists.xenproject.org

>>> On 22.03.11 at 20:21, Olaf Hering <olaf@aepfle.de> wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1300813820 -3600
> # Node ID dcbae547cce81f10c243d54bd35fd139615313cb
> # Parent  e58f6949e76a2786c4f5a99a0da44ee58743b4df
> xentrace: use consistent printk prefix

Why "Xen trace buffers: " and not e.g. "xtb: "?

Jan

> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>=20
> diff -r e58f6949e76a -r dcbae547cce8 xen/common/trace.c
> --- a/xen/common/trace.c	Tue Mar 22 18:08:19 2011 +0100
> +++ b/xen/common/trace.c	Tue Mar 22 18:10:20 2011 +0100
> @@ -117,7 +117,7 @@
>      size /=3D PAGE_SIZE;
>      if ( pages > size )
>      {
> -        printk(XENLOG_INFO "%s: requested number of %u pages reduced =
to=20
> %u\n",
> +        printk(XENLOG_INFO "Xen trace buffers: %s: requested number of =
%u=20
> pages reduced to %u\n",
>                 __func__, pages, (unsigned int)size);
>          pages =3D size;
>      }
> @@ -177,7 +177,7 @@
>          if ( (rawbuf =3D alloc_xenheap_pages(
>                  order, MEMF_bits(32 + PAGE_SHIFT))) =3D=3D NULL )
>          {
> -            printk("Xen trace buffers: memory allocation failed on =
cpu=20
> %d\n", cpu);
> +            printk(XENLOG_INFO "Xen trace buffers: memory allocation =
failed=20
> on cpu %d\n", cpu);
>              goto out_dealloc;
>          }
> =20
> @@ -212,7 +212,7 @@
>              t_info_mfn_list[offset + i]=3Dmfn + i;
>          }
>          t_info->mfn_offset[cpu]=3Doffset;
> -        printk(XENLOG_INFO "p%d mfn %"PRIx32" offset %d\n",
> +        printk(XENLOG_INFO "Xen trace buffers: p%d mfn %"PRIx32" =
offset=20
> %d\n",
>                 cpu, mfn, offset);
>          offset+=3Di;
> =20
> @@ -236,7 +236,7 @@
>      {
>          void *rawbuf =3D per_cpu(t_bufs, cpu);
>          per_cpu(t_bufs, cpu) =3D NULL;
> -        printk("Xen trace buffers: cpu %d p %p\n", cpu, rawbuf);
> +        printk(XENLOG_DEBUG "Xen trace buffers: cpu %d p %p\n", cpu,=20
> rawbuf);
>          if ( rawbuf )
>          {
>              ASSERT(!(virt_to_page(rawbuf)->count_info & PGC_allocated));=

> @@ -245,7 +245,7 @@
>      }
>      free_xenheap_pages(t_info, get_order_from_pages(t_info_pages));
>      t_info =3D NULL;
> -    printk("Xen trace buffers: allocation failed! Tracing disabled.\n");=

> +    printk(XENLOG_WARNING "Xen trace buffers: allocation failed! =
Tracing=20
> disabled.\n");
>      return -ENOMEM;
>  }
> =20
> @@ -264,7 +264,7 @@
>       */
>      if ( opt_tbuf_size && pages !=3D opt_tbuf_size )
>      {
> -        printk(XENLOG_INFO "tb_set_size from %d to %d not implemented\n"=
,
> +        printk(XENLOG_INFO "Xen trace buffers: tb_set_size from %d to =
%d=20
> not implemented\n",
>                       opt_tbuf_size, pages);
>          return -EINVAL;
>      }
>=20
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com=20
> http://lists.xensource.com/xen-devel=20