From: "Jan Beulich" <JBeulich@novell.com>
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: [PATCH] switch rangeset's lock to rwlock
Date: Fri, 25 Mar 2011 16:49:47 +0000 [thread overview]
Message-ID: <4D8CD5BB02000078000386C1@vpn.id2.novell.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2795 bytes --]
As a general library routine, it should behave as efficiently as
possible, even if at present no significant contention is known here.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
--- a/xen/common/rangeset.c
+++ b/xen/common/rangeset.c
@@ -25,7 +25,7 @@ struct rangeset {
/* Ordered list of ranges contained in this set, and protecting lock. */
struct list_head range_list;
- spinlock_t lock;
+ rwlock_t lock;
/* Pretty-printing name. */
char name[32];
@@ -103,7 +103,7 @@ int rangeset_add_range(
ASSERT(s <= e);
- spin_lock(&r->lock);
+ write_lock(&r->lock);
x = find_range(r, s);
y = find_range(r, e);
@@ -159,7 +159,7 @@ int rangeset_add_range(
}
out:
- spin_unlock(&r->lock);
+ write_unlock(&r->lock);
return rc;
}
@@ -175,7 +175,7 @@ int rangeset_remove_range(
ASSERT(s <= e);
- spin_lock(&r->lock);
+ write_lock(&r->lock);
x = find_range(r, s);
y = find_range(r, e);
@@ -231,7 +231,7 @@ int rangeset_remove_range(
}
out:
- spin_unlock(&r->lock);
+ write_unlock(&r->lock);
return rc;
}
@@ -243,10 +243,10 @@ int rangeset_contains_range(
ASSERT(s <= e);
- spin_lock(&r->lock);
+ read_lock(&r->lock);
x = find_range(r, s);
contains = (x && (x->e >= e));
- spin_unlock(&r->lock);
+ read_unlock(&r->lock);
return contains;
}
@@ -259,10 +259,10 @@ int rangeset_overlaps_range(
ASSERT(s <= e);
- spin_lock(&r->lock);
+ read_lock(&r->lock);
x = find_range(r, e);
overlaps = (x && (s <= x->e));
- spin_unlock(&r->lock);
+ read_unlock(&r->lock);
return overlaps;
}
@@ -274,13 +274,13 @@ int rangeset_report_ranges(
struct range *x;
int rc = 0;
- spin_lock(&r->lock);
+ read_lock(&r->lock);
for ( x = find_range(r, s); x && (x->s <= e) && !rc; x = next_range(r, x) )
if ( x->e >= s )
rc = cb(max(x->s, s), min(x->e, e), ctxt);
- spin_unlock(&r->lock);
+ read_unlock(&r->lock);
return rc;
}
@@ -318,7 +318,7 @@ struct rangeset *rangeset_new(
if ( r == NULL )
return NULL;
- spin_lock_init(&r->lock);
+ rwlock_init(&r->lock);
INIT_LIST_HEAD(&r->range_list);
BUG_ON(flags & ~RANGESETF_prettyprint_hex);
@@ -403,7 +403,7 @@ void rangeset_printk(
int nr_printed = 0;
struct range *x;
- spin_lock(&r->lock);
+ read_lock(&r->lock);
printk("%-10s {", r->name);
@@ -422,7 +422,7 @@ void rangeset_printk(
printk(" }");
- spin_unlock(&r->lock);
+ read_unlock(&r->lock);
}
void rangeset_domain_printk(
[-- Attachment #2: rangesets-rwlock.patch --]
[-- Type: text/plain, Size: 2789 bytes --]
As a general library routine, it should behave as efficiently as
possible, even if at present no significant contention is known here.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
--- a/xen/common/rangeset.c
+++ b/xen/common/rangeset.c
@@ -25,7 +25,7 @@ struct rangeset {
/* Ordered list of ranges contained in this set, and protecting lock. */
struct list_head range_list;
- spinlock_t lock;
+ rwlock_t lock;
/* Pretty-printing name. */
char name[32];
@@ -103,7 +103,7 @@ int rangeset_add_range(
ASSERT(s <= e);
- spin_lock(&r->lock);
+ write_lock(&r->lock);
x = find_range(r, s);
y = find_range(r, e);
@@ -159,7 +159,7 @@ int rangeset_add_range(
}
out:
- spin_unlock(&r->lock);
+ write_unlock(&r->lock);
return rc;
}
@@ -175,7 +175,7 @@ int rangeset_remove_range(
ASSERT(s <= e);
- spin_lock(&r->lock);
+ write_lock(&r->lock);
x = find_range(r, s);
y = find_range(r, e);
@@ -231,7 +231,7 @@ int rangeset_remove_range(
}
out:
- spin_unlock(&r->lock);
+ write_unlock(&r->lock);
return rc;
}
@@ -243,10 +243,10 @@ int rangeset_contains_range(
ASSERT(s <= e);
- spin_lock(&r->lock);
+ read_lock(&r->lock);
x = find_range(r, s);
contains = (x && (x->e >= e));
- spin_unlock(&r->lock);
+ read_unlock(&r->lock);
return contains;
}
@@ -259,10 +259,10 @@ int rangeset_overlaps_range(
ASSERT(s <= e);
- spin_lock(&r->lock);
+ read_lock(&r->lock);
x = find_range(r, e);
overlaps = (x && (s <= x->e));
- spin_unlock(&r->lock);
+ read_unlock(&r->lock);
return overlaps;
}
@@ -274,13 +274,13 @@ int rangeset_report_ranges(
struct range *x;
int rc = 0;
- spin_lock(&r->lock);
+ read_lock(&r->lock);
for ( x = find_range(r, s); x && (x->s <= e) && !rc; x = next_range(r, x) )
if ( x->e >= s )
rc = cb(max(x->s, s), min(x->e, e), ctxt);
- spin_unlock(&r->lock);
+ read_unlock(&r->lock);
return rc;
}
@@ -318,7 +318,7 @@ struct rangeset *rangeset_new(
if ( r == NULL )
return NULL;
- spin_lock_init(&r->lock);
+ rwlock_init(&r->lock);
INIT_LIST_HEAD(&r->range_list);
BUG_ON(flags & ~RANGESETF_prettyprint_hex);
@@ -403,7 +403,7 @@ void rangeset_printk(
int nr_printed = 0;
struct range *x;
- spin_lock(&r->lock);
+ read_lock(&r->lock);
printk("%-10s {", r->name);
@@ -422,7 +422,7 @@ void rangeset_printk(
printk(" }");
- spin_unlock(&r->lock);
+ read_unlock(&r->lock);
}
void rangeset_domain_printk(
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next reply other threads:[~2011-03-25 16:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 16:49 Jan Beulich [this message]
2011-03-25 17:08 ` [PATCH] switch rangeset's lock to rwlock Keir Fraser
2011-03-25 17:52 ` Dan Magenheimer
2011-03-25 20:52 ` Keir Fraser
2011-03-30 22:44 ` Jeremy Fitzhardinge
2011-03-28 8:23 ` Jan Beulich
2011-03-28 8:54 ` Keir Fraser
-- strict thread matches above, loose matches on Subject: below --
2014-09-12 12:55 Jan Beulich
2014-09-18 10:43 ` Tim Deegan
2014-09-18 12:15 ` Jan Beulich
2014-09-18 13:02 ` Tim Deegan
2014-09-18 13:32 ` Jan Beulich
2014-09-18 14:52 ` Paul Durrant
2014-09-19 16:33 ` Konrad Rzeszutek Wilk
2014-09-22 9:42 ` Ian Campbell
2014-09-22 10:34 ` Jan Beulich
2014-09-19 16:32 ` Konrad Rzeszutek Wilk
2014-09-30 8:50 ` Jan Beulich
2014-09-30 12:01 ` Tim Deegan
2014-09-30 20:53 ` Keir Fraser
2014-10-01 8:57 ` Jan Beulich
2014-10-01 9:31 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8CD5BB02000078000386C1@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).