From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: arch_set_info_guest() producing inconsistent state on x86? Date: Tue, 29 Mar 2011 12:45:38 +0100 Message-ID: <4D91E2820200007800038D68@vpn.id2.novell.com> References: <4D91AE140200007800038CF7@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "xen-devel@lists.xensource.com" Cc: Keir Fraser List-Id: xen-devel@lists.xenproject.org >>> On 29.03.11 at 11:59, Keir Fraser wrote: > On 29/03/2011 09:01, "Jan Beulich" wrote: >=20 >> The question is whether it must be considered legal to issue >> XEN_DOMCTL_setvcpucontext on an already initialized vCPU >> in the first place. >=20 > It's probably used by debuggers running in dom0? Also see > modify_returncode() in libxc/xc_resume.c -- so it's used on suspend = resume > in the failure case. >=20 > I doubt anything other than GPRs are ever modified after first > initialisation. So should we then perhaps make the function check the bits it doesn't really update match what is in place already? Jan