xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Jan Beulich <JBeulich@novell.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Drew Jones <drjones@redhat.com>
Subject: preempt_disable() imbalance in take_machine_down()? [linux-2.6.18-xen.hg]
Date: Tue, 05 Apr 2011 15:59:13 +0200	[thread overview]
Message-ID: <4D9B2031.5080100@redhat.com> (raw)

Hi,

please excuse the lame question.

Looking at take_machine_down() and __xen_suspend() in 
"drivers/xen/core/machine_reboot.c", assuming "fast_suspend" is false, 
it seems that after the loop in take_machine_down() completes, 
preempt_enable() is never called. Is this intentional? If so, how/why 
does it work?

Thank you very much,
Laszlo Ersek

             reply	other threads:[~2011-04-05 13:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-05 13:59 Laszlo Ersek [this message]
2011-04-05 14:18 ` preempt_disable() imbalance in take_machine_down()? [linux-2.6.18-xen.hg] Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D9B2031.5080100@redhat.com \
    --to=lersek@redhat.com \
    --cc=JBeulich@novell.com \
    --cc=drjones@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).