From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laszlo Ersek <lersek@redhat.com>
Subject: preempt_disable() imbalance in take_machine_down()?
	[linux-2.6.18-xen.hg]
Date: Tue, 05 Apr 2011 15:59:13 +0200
Message-ID: <4D9B2031.5080100@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Jan Beulich <JBeulich@novell.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Drew Jones <drjones@redhat.com>
List-Id: xen-devel@lists.xenproject.org

Hi,

please excuse the lame question.

Looking at take_machine_down() and __xen_suspend() in 
"drivers/xen/core/machine_reboot.c", assuming "fast_suspend" is false, 
it seems that after the loop in take_machine_down() completes, 
preempt_enable() is never called. Is this intentional? If so, how/why 
does it work?

Thank you very much,
Laszlo Ersek