* preempt_disable() imbalance in take_machine_down()? [linux-2.6.18-xen.hg]
@ 2011-04-05 13:59 Laszlo Ersek
2011-04-05 14:18 ` Jan Beulich
0 siblings, 1 reply; 2+ messages in thread
From: Laszlo Ersek @ 2011-04-05 13:59 UTC (permalink / raw)
To: xen-devel@lists.xensource.com, Jan Beulich; +Cc: Paolo Bonzini, Drew Jones
Hi,
please excuse the lame question.
Looking at take_machine_down() and __xen_suspend() in
"drivers/xen/core/machine_reboot.c", assuming "fast_suspend" is false,
it seems that after the loop in take_machine_down() completes,
preempt_enable() is never called. Is this intentional? If so, how/why
does it work?
Thank you very much,
Laszlo Ersek
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: preempt_disable() imbalance in take_machine_down()? [linux-2.6.18-xen.hg]
2011-04-05 13:59 preempt_disable() imbalance in take_machine_down()? [linux-2.6.18-xen.hg] Laszlo Ersek
@ 2011-04-05 14:18 ` Jan Beulich
0 siblings, 0 replies; 2+ messages in thread
From: Jan Beulich @ 2011-04-05 14:18 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: Paolo Bonzini, Drew Jones, xen-devel@lists.xensource.com
>>> On 05.04.11 at 15:59, Laszlo Ersek <lersek@redhat.com> wrote:
> Looking at take_machine_down() and __xen_suspend() in
> "drivers/xen/core/machine_reboot.c", assuming "fast_suspend" is false,
> it seems that after the loop in take_machine_down() completes,
> preempt_enable() is never called. Is this intentional?
Probably not.
> If so, how/why does it work?
Because PREEMPT depends on !XEN in kernel/Kconfig.preempt.
Jan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-05 14:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-05 13:59 preempt_disable() imbalance in take_machine_down()? [linux-2.6.18-xen.hg] Laszlo Ersek
2011-04-05 14:18 ` Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).