From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@novell.com>
Subject: Re: [PATCH] xen: fix hypervisor crash with
	 xentrace
Date: Wed, 06 Apr 2011 16:01:08 +0100
Message-ID: <4D9C9C54020000780003A327@vpn.id2.novell.com>
References: <201104061632.02099.Christoph.Egger@amd.com>
	<4D9C7A56.8070007@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4D9C7A56.8070007@amd.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

>>> On 06.04.11 at 16:36, Christoph Egger <Christoph.Egger@amd.com> wrote:
> On 04/06/11 16:32, Christoph Egger wrote:
>>
>> Hi,
>>
>> Attached patch fixes hypervisor crashes when xentrace buffer gets=20
> initialized.
>=20
> Forgot to mention this regression was introduced in c/s=20
> 23134:f5d33782a57b by Jan Beulich.

But just removing the __init-s isn't the right way to fix this (Did
you notice the comment in register_cpu_notifier(), which I also
pointed out in the changeset description). Apparently I overlooked
a call to register_cpu_notifier(), and it's that which ought to get
moved into an __init function.

Jan