From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH V3] AMD IOMMU: Fix an interrupt remapping issue Date: Mon, 11 Apr 2011 12:35:00 +0100 Message-ID: <4DA30384020000780003ADEA@vpn.id2.novell.com> References: <201104081335.36718.wei.wang2@amd.com> <201104081852.20738.wei.wang2@amd.com> <4DA2C89A020000780003AD92@vpn.id2.novell.com> <201104111231.24422.wei.wang2@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <201104111231.24422.wei.wang2@amd.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Wei Wang2 Cc: Boris Ostrovsky , Wei Huang2 , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org >>> On 11.04.11 at 12:31, Wei Wang2 wrote: > This patch is the latest. Should have addressed all of your concerns. = Please=20 > take a look. Looks good to me now. Assuming it also still addresses the problem at hand: Acked-by: Jan Beulich Thanks, Jan > Thanks, > Wei >=20 > Signed-off-by: Wei Wang >=20 > On Monday 11 April 2011 09:23:38 Jan Beulich wrote: >> >>> On 08.04.11 at 18:52, Wei Wang2 wrote: >> > >> > Jan, How dose this one look like to you? >> >> Much better, but still not quite there: The unmasking must happen >> *after* the writing of the upper half (if that's what is being = modified). >> >> You could also skip the unmasking altogether if saved_mask =3D=3D 1. >> >> And if you start using __io_apic_write() (which I find very desirable) >> is there a reason not to use it (and __io_apic_read()) in all of the >> other places you touch anyway, too? >> >> Jan