Re: [Xen-devel] [PATCH 2/4] x86, xen: introduce x86_init.mapping.pagetable_reserve

["Jan Beulich" <JBeulich@novell.com>]

>>> On 12.04.11 at 13:19, <stefano.stabellini@eu.citrix.com> wrote:
> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> index 6b833db..fec8680 100644
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -1275,6 +1275,20 @@ static __init void xen_pagetable_setup_start(pgd_t 
> *base)
>  {
>  }
>  
> +static __init void xen_mapping_pagetable_reserve(u64 start, u64 end)
> +{
> +	/* reserve the range used */
> +	memblock_x86_reserve_range(start, end, "PGTABLE");

Wouldn't it be more natural (and involving less future changes) if
you called native_pagetable_reserve() here?

Jan

> +
> +	/* set as RW the rest */
> +	printk(KERN_DEBUG "xen: setting RW the range %llx - %llx\n", end,
> +			PFN_PHYS(pgt_buf_top));
> +	while (end < PFN_PHYS(pgt_buf_top)) {
> +		make_lowmem_page_readwrite(__va(end));
> +		end += PAGE_SIZE;
> +	}
> +}
> +
>  static void xen_post_allocator_init(void);
>  
>  static __init void xen_pagetable_setup_done(pgd_t *base)