From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] nestedhvm: xentrace support Date: Thu, 14 Apr 2011 16:36:36 +0200 Message-ID: <4DA70674.2090203@amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 04/14/11 16:00, Keir Fraser wrote: > On 13/04/2011 16:34, "Christoph Egger" wrote: > >> >> Tracing facility for nested virtualization >> >> Signed-off-by: Christoph Egger > > I fixed this, by adding an extra argument to HVMTRACE_ND() -- it wasn't > really valid to make the first argument be an arbitarry C expression, due to > argument concatenation that then went on in the macro body. Thanks for your effort. > I also discarded the change to the VMENTRY record to add the guest EIP. > Firstly, it was incomplete, because it did not handle 64-bit RIP. Secondly, > it does not logically belong in this patch. Finally, George may have a > reason for not including RIP in VMENTRY records (e.g., not that useful > compared with the extra space taken up in trace records). So you'd need to > submit a new patch and get an Ack from George (who is currently on holiday). Ok. If he has one I would like to know it. For nested virtualization it is at least good debugging information to see if the l2 guest loops somewhere or not. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632