From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: [PATCH]tools/libxl: fix a bug in
	libxl__build_device_model_args_new.
	info->vncpasswd can't be empty if info->vncpasswd != NULL
Date: Fri, 15 Apr 2011 11:37:57 +0200
Message-ID: <4DA811F5.3080106@amd.com>
References: <BANLkTikOiFNm5OM+JFtpW6_32zTtpcUQYA@mail.gmail.com>	<4DA801C4.5060102@amd.com>
	<BANLkTikKZOOfstWHCu_iD_JxsBmjx8HsxA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <BANLkTikKZOOfstWHCu_iD_JxsBmjx8HsxA@mail.gmail.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: ZhouPeng <zpengxen@gmail.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "ian.campbell@citrix.com" <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 04/15/11 11:36, ZhouPeng wrote:
>
>
> 2011/4/15 Christoph Egger<Christoph.Egger@amd.com<mailto:Christoph.Egge=
r@amd.com>>
> On 04/15/11 10:33, ZhouPeng wrote:
> Signed-off-by: Zhou Peng<zhoupeng@nfs.iscas.ac.cn<mailto:zhoupeng@nfs.i=
scas.ac.cn>>
>
> tools/libxl: fix a bug in libxl__build_device_model_args_new. info->vnc=
passwd can't be empty if info->vncpasswd !=3D NULL
>
>
> NACK!  This can info->vncpasswd[0] contains '\0' if you have
>
>
>    vncpasswd=3D''
>
> in the guest config file.
>
>   " if (info->vncpasswd&&   info->vncpasswd[0]) =93 can
>    vncpasswd=3D'' in guest cfg file, when using upstream-qemu-xen
>    and block vncpasswd=3D'passwd'
>    Can it be reasonable?
>


Does that mean upstream qemu-xen and in-tree qemu-xen behave differently?

Christoph


--=20
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632