From: "Jan Beulich" <JBeulich@novell.com>
To: Jacob Shin <jacob.shin@amd.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH 2/3] xenoprof: Add support for AMD Family 15h processors
Date: Thu, 05 May 2011 08:38:18 +0100 [thread overview]
Message-ID: <4DC2700A020000780003FC63@vpn.id2.novell.com> (raw)
In-Reply-To: <4DC1F8B2.7080001@amd.com>
>>> On 05.05.11 at 03:09, Jacob Shin <jacob.shin@amd.com> wrote:
> # HG changeset patch
> # User Jacob Shin <jacob.shin@amd.com>
> # Date 1304524596 18000
> # Node ID 349a9e537940f8bc340a2055cb5068b58809042f
> # Parent eeb1bb50ba13c36e44d4994e01d82d294f3c584a
> xenoprof: Add support for AMD Family 15h processors
>
> AMD Family 15h CPU mirrors legacy K7 performance monitor counters to
> a new location, and adds 2 new counters. This patch updates xenoprof
> to take advantage of the new counters.
>
> Signed-off-by: Jacob Shin <jacob.shin@amd.com>
>
> diff -r eeb1bb50ba13 -r 349a9e537940 xen/arch/x86/oprofile/nmi_int.c
> --- a/xen/arch/x86/oprofile/nmi_int.c Tue May 03 17:26:33 2011 -0500
> +++ b/xen/arch/x86/oprofile/nmi_int.c Wed May 04 10:56:36 2011 -0500
> @@ -30,7 +30,7 @@ struct op_counter_config counter_config[
> struct op_counter_config counter_config[OP_MAX_COUNTER];
> struct op_ibs_config ibs_config;
>
> -static struct op_x86_model_spec const *__read_mostly model;
> +struct op_x86_model_spec const *__read_mostly model;
> static struct op_msrs cpu_msrs[NR_CPUS];
> static unsigned long saved_lvtpc[NR_CPUS];
>
> @@ -446,7 +446,7 @@ static int __init nmi_init(void)
> cpu_type = "x86-64/family14h";
> break;
> case 0x15:
> - model = &op_athlon_spec;
> + model = &op_fam15h_spec;
Let's please call this op_amd_fam15h_spec.
Jan
> cpu_type = "x86-64/family15h";
> break;
> }
> diff -r eeb1bb50ba13 -r 349a9e537940 xen/arch/x86/oprofile/op_model_athlon.c
> --- a/xen/arch/x86/oprofile/op_model_athlon.c Tue May 03 17:26:33 2011 -0500
> +++ b/xen/arch/x86/oprofile/op_model_athlon.c Wed May 04 10:56:36 2011 -0500
> @@ -24,8 +24,13 @@
> #include "op_x86_model.h"
> #include "op_counter.h"
>
> -#define NUM_COUNTERS 4
> -#define NUM_CONTROLS 4
> +#define K7_NUM_COUNTERS 4
> +#define K7_NUM_CONTROLS 4
> +
> +#define FAM15H_NUM_COUNTERS 6
> +#define FAM15H_NUM_CONTROLS 6
> +
> +#define MAX_COUNTERS FAM15H_NUM_COUNTERS
>
> #define CTR_READ(msr_content,msrs,c) do {rdmsrl(msrs->counters[(c)].addr,
> (msr_content));} while (0)
> #define CTR_WRITE(l,msrs,c) do {wrmsr(msrs->counters[(c)].addr, -(unsigned
> int)(l), -1);} while (0)
> @@ -44,9 +49,10 @@
> #define CTRL_SET_HOST_ONLY(val, h) (val |= ((h & 0x1ULL) << 41))
> #define CTRL_SET_GUEST_ONLY(val, h) (val |= ((h & 0x1ULL) << 40))
>
> -static unsigned long reset_value[NUM_COUNTERS];
> +static unsigned long reset_value[MAX_COUNTERS];
>
> extern char svm_stgi_label[];
> +extern struct op_x86_model_spec const *__read_mostly model;
>
> #ifdef CONFIG_X86_64
> u32 ibs_caps = 0;
> @@ -175,26 +181,44 @@ static void athlon_fill_in_addresses(str
> msrs->controls[3].addr = MSR_K7_EVNTSEL3;
> }
>
> -
> +static void fam15h_fill_in_addresses(struct op_msrs * const msrs)
> +{
> + msrs->counters[0].addr = MSR_FAM15H_PERFCTR0;
> + msrs->counters[1].addr = MSR_FAM15H_PERFCTR1;
> + msrs->counters[2].addr = MSR_FAM15H_PERFCTR2;
> + msrs->counters[3].addr = MSR_FAM15H_PERFCTR3;
> + msrs->counters[4].addr = MSR_FAM15H_PERFCTR4;
> + msrs->counters[5].addr = MSR_FAM15H_PERFCTR5;
> +
> + msrs->controls[0].addr = MSR_FAM15H_EVNTSEL0;
> + msrs->controls[1].addr = MSR_FAM15H_EVNTSEL1;
> + msrs->controls[2].addr = MSR_FAM15H_EVNTSEL2;
> + msrs->controls[3].addr = MSR_FAM15H_EVNTSEL3;
> + msrs->controls[4].addr = MSR_FAM15H_EVNTSEL4;
> + msrs->controls[5].addr = MSR_FAM15H_EVNTSEL5;
> +}
> +
> static void athlon_setup_ctrs(struct op_msrs const * const msrs)
> {
> uint64_t msr_content;
> int i;
> + unsigned int const nr_ctrs = model->num_counters;
> + unsigned int const nr_ctrls = model->num_controls;
>
> /* clear all counters */
> - for (i = 0 ; i < NUM_CONTROLS; ++i) {
> + for (i = 0 ; i < nr_ctrls; ++i) {
> CTRL_READ(msr_content, msrs, i);
> CTRL_CLEAR(msr_content);
> CTRL_WRITE(msr_content, msrs, i);
> }
>
> /* avoid a false detection of ctr overflows in NMI handler */
> - for (i = 0; i < NUM_COUNTERS; ++i) {
> + for (i = 0; i < nr_ctrs; ++i) {
> CTR_WRITE(1, msrs, i);
> }
>
> /* enable active counters */
> - for (i = 0; i < NUM_COUNTERS; ++i) {
> + for (i = 0; i < nr_ctrs; ++i) {
> if (counter_config[i].enabled) {
> reset_value[i] = counter_config[i].count;
>
> @@ -300,6 +324,7 @@ static int athlon_check_ctrs(unsigned in
> int mode = 0;
> struct vcpu *v = current;
> struct cpu_user_regs *guest_regs = guest_cpu_user_regs();
> + unsigned int const nr_ctrs = model->num_counters;
>
> if (!guest_mode(regs) &&
> (regs->eip == (unsigned long)svm_stgi_label)) {
> @@ -312,7 +337,7 @@ static int athlon_check_ctrs(unsigned in
> mode = xenoprofile_get_mode(v, regs);
> }
>
> - for (i = 0 ; i < NUM_COUNTERS; ++i) {
> + for (i = 0 ; i < nr_ctrs; ++i) {
> CTR_READ(msr_content, msrs, i);
> if (CTR_OVERFLOWED(msr_content)) {
> xenoprof_log_event(current, regs, eip, mode, i);
> @@ -373,7 +398,8 @@ static void athlon_start(struct op_msrs
> {
> uint64_t msr_content;
> int i;
> - for (i = 0 ; i < NUM_COUNTERS ; ++i) {
> + unsigned int const nr_ctrs = model->num_counters;
> + for (i = 0 ; i < nr_ctrs ; ++i) {
> if (reset_value[i]) {
> CTRL_READ(msr_content, msrs, i);
> CTRL_SET_ACTIVE(msr_content);
> @@ -401,10 +427,11 @@ static void athlon_stop(struct op_msrs c
> {
> uint64_t msr_content;
> int i;
> + unsigned int const nr_ctrs = model->num_counters;
>
> /* Subtle: stop on all counters to avoid race with
> * setting our pm callback */
> - for (i = 0 ; i < NUM_COUNTERS ; ++i) {
> + for (i = 0 ; i < nr_ctrs ; ++i) {
> CTRL_READ(msr_content, msrs, i);
> CTRL_SET_INACTIVE(msr_content);
> CTRL_WRITE(msr_content, msrs, i);
> @@ -512,11 +539,21 @@ void __init ibs_init(void)
> #endif /* CONFIG_X86_64 */
>
> struct op_x86_model_spec const op_athlon_spec = {
> - .num_counters = NUM_COUNTERS,
> - .num_controls = NUM_CONTROLS,
> + .num_counters = K7_NUM_COUNTERS,
> + .num_controls = K7_NUM_CONTROLS,
> .fill_in_addresses = &athlon_fill_in_addresses,
> .setup_ctrs = &athlon_setup_ctrs,
> .check_ctrs = &athlon_check_ctrs,
> .start = &athlon_start,
> .stop = &athlon_stop
> };
> +
> +struct op_x86_model_spec const op_fam15h_spec = {
> + .num_counters = FAM15H_NUM_COUNTERS,
> + .num_controls = FAM15H_NUM_CONTROLS,
> + .fill_in_addresses = &fam15h_fill_in_addresses,
> + .setup_ctrs = &athlon_setup_ctrs,
> + .check_ctrs = &athlon_check_ctrs,
> + .start = &athlon_start,
> + .stop = &athlon_stop
> +};
> diff -r eeb1bb50ba13 -r 349a9e537940 xen/arch/x86/oprofile/op_x86_model.h
> --- a/xen/arch/x86/oprofile/op_x86_model.h Tue May 03 17:26:33 2011 -0500
> +++ b/xen/arch/x86/oprofile/op_x86_model.h Wed May 04 10:56:36 2011 -0500
> @@ -48,6 +48,7 @@ extern struct op_x86_model_spec const op
> extern struct op_x86_model_spec const op_p4_spec;
> extern struct op_x86_model_spec const op_p4_ht2_spec;
> extern struct op_x86_model_spec const op_athlon_spec;
> +extern struct op_x86_model_spec const op_fam15h_spec;
>
> void arch_perfmon_setup_counters(void);
> #endif /* OP_X86_MODEL_H */
> diff -r eeb1bb50ba13 -r 349a9e537940 xen/include/asm-x86/msr-index.h
> --- a/xen/include/asm-x86/msr-index.h Tue May 03 17:26:33 2011 -0500
> +++ b/xen/include/asm-x86/msr-index.h Wed May 04 10:56:36 2011 -0500
> @@ -223,6 +223,19 @@
> #define MSR_K8_ENABLE_C1E 0xc0010055
> #define MSR_K8_VM_CR 0xc0010114
> #define MSR_K8_VM_HSAVE_PA 0xc0010117
> +
> +#define MSR_FAM15H_EVNTSEL0 0xc0010200
> +#define MSR_FAM15H_PERFCTR0 0xc0010201
> +#define MSR_FAM15H_EVNTSEL1 0xc0010202
> +#define MSR_FAM15H_PERFCTR1 0xc0010203
> +#define MSR_FAM15H_EVNTSEL2 0xc0010204
> +#define MSR_FAM15H_PERFCTR2 0xc0010205
> +#define MSR_FAM15H_EVNTSEL3 0xc0010206
> +#define MSR_FAM15H_PERFCTR3 0xc0010207
> +#define MSR_FAM15H_EVNTSEL4 0xc0010208
> +#define MSR_FAM15H_PERFCTR4 0xc0010209
> +#define MSR_FAM15H_EVNTSEL5 0xc001020a
> +#define MSR_FAM15H_PERFCTR5 0xc001020b
>
> #define MSR_K8_FEATURE_MASK 0xc0011004
> #define MSR_K8_EXT_FEATURE_MASK 0xc0011005
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2011-05-05 7:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 0:54 [PATCH 0/3] AMD Family 15h Performance Monitor Counters patches Jacob Shin
2011-05-05 1:09 ` [PATCH 1/3] xenoprof: Update cpu_type to sync with upstream oprofile Jacob Shin
2011-05-05 1:09 ` [PATCH 2/3] xenoprof: Add support for AMD Family 15h processors Jacob Shin
2011-05-05 7:38 ` Jan Beulich [this message]
2011-05-05 1:09 ` [PATCH 3/3] hvm: vpmu: " Jacob Shin
2011-05-05 7:43 ` Jan Beulich
2011-05-10 17:00 ` Jacob Shin
2011-05-10 17:20 ` Keir Fraser
-- strict thread matches above, loose matches on Subject: below --
2011-05-05 7:41 [PATCH 2/3] xenoprof: " Jan Beulich
2011-05-10 16:56 ` Jacob Shin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC2700A020000780003FC63@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=jacob.shin@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).