xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: Wei Huang2 <Wei.Huang2@amd.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 6 of 8] FPU: create lazy and non-lazy FPU restore functions
Date: Mon, 09 May 2011 09:37:17 +0100	[thread overview]
Message-ID: <4DC7C3DD020000780004054D@vpn.id2.novell.com> (raw)
In-Reply-To: <EE335F95F28A664DB4A21289D2AA053BD160129E@SAUSEXMBP01.amd.com>

>>> On 07.05.11 at 07:42, "Huang2, Wei" <Wei.Huang2@amd.com> wrote:
>--- a/xen/arch/x86/i387.c	Fri May 06 10:40:22 2011 -0500
>+++ b/xen/arch/x86/i387.c	Fri May 06 10:53:35 2011 -0500
>@@ -98,13 +98,13 @@
> /*      FPU Save Functions     */
> /*******************************/
> /* Save x87 extended state */
>-static inline void fpu_xsave(struct vcpu *v, uint64_t mask)
>+static inline void fpu_xsave(struct vcpu *v)

This looks okay now to me, only a cosmetic comment: You add the
"mask" parameter in patch 5, just to remove it here again.

Jan

  reply	other threads:[~2011-05-09  8:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <patchbomb.1304747132@weisles1164.amd.com>
2011-05-07  5:39 ` [PATCH 0 of 8] FPU LWP: patch description Huang2, Wei
2011-05-09  8:39   ` Jan Beulich
     [not found] ` <439311a108d71aba1580.1304747133@weisles1164.amd.com>
2011-05-07  5:40   ` [PATCH 1 of 8] FPU: extract extended related code into xstate.h and xstate.c Huang2, Wei
     [not found] ` <eb6f1c5d0c7e688df083.1304747134@weisles1164.amd.com>
2011-05-07  5:40   ` [PATCH 2 of 8] FPU: create FPU init and destroy functions Huang2, Wei
     [not found] ` <5560826d130f143c8aec.1304747135@weisles1164.amd.com>
2011-05-07  5:41   ` [PATCH 3 of 8] FPU: clean up FPU context save function Huang2, Wei
     [not found] ` <5badff7cda6b4af71991.1304747136@weisles1164.amd.com>
2011-05-07  5:42   ` [PATCH 4 of 8] FPU: clean up FPU context restore function Huang2, Wei
     [not found] ` <ab7d2191421fbf95313e.1304747137@weisles1164.amd.com>
2011-05-07  5:42   ` [PATCH 5 of 8] FPU: add mask parameter to xsave and xrstor Huang2, Wei
     [not found] ` <e58b1d06aabe5c0aa26f.1304747138@weisles1164.amd.com>
2011-05-07  5:42   ` [PATCH 6 of 8] FPU: create lazy and non-lazy FPU restore functions Huang2, Wei
2011-05-09  8:37     ` Jan Beulich [this message]
     [not found] ` <92b0ed16c09da1fb24f5.1304747139@weisles1164.amd.com>
2011-05-07  5:43   ` [PATCH 7 of 8] LWP: export LWP related CPUID to AMD SVM guest Huang2, Wei
     [not found] ` <ea027ce41fb45a619d39.1304747140@weisles1164.amd.com>
2011-05-07  5:43   ` [PATCH 8 of 8] LWP: Add LWP support for SVM guests Huang2, Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DC7C3DD020000780004054D@vpn.id2.novell.com \
    --to=jbeulich@novell.com \
    --cc=Wei.Huang2@amd.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).