From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@novell.com>
Subject: Re: [PATCH 6 of 8] FPU: create lazy and non-lazy
	FPU restore functions
Date: Mon, 09 May 2011 09:37:17 +0100
Message-ID: <4DC7C3DD020000780004054D@vpn.id2.novell.com>
References: <patchbomb.1304747132@weisles1164.amd.com>,
	<e58b1d06aabe5c0aa26f.1304747138@weisles1164.amd.com>
	<EE335F95F28A664DB4A21289D2AA053BD160129E@SAUSEXMBP01.amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <EE335F95F28A664DB4A21289D2AA053BD160129E@SAUSEXMBP01.amd.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Wei Huang2 <Wei.Huang2@amd.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

>>> On 07.05.11 at 07:42, "Huang2, Wei" <Wei.Huang2@amd.com> wrote:
>--- a/xen/arch/x86/i387.c	Fri May 06 10:40:22 2011 -0500
>+++ b/xen/arch/x86/i387.c	Fri May 06 10:53:35 2011 -0500
>@@ -98,13 +98,13 @@
> /*      FPU Save Functions     */
> /*******************************/
> /* Save x87 extended state */
>-static inline void fpu_xsave(struct vcpu *v, uint64_t mask)
>+static inline void fpu_xsave(struct vcpu *v)

This looks okay now to me, only a cosmetic comment: You add the
"mask" parameter in patch 5, just to remove it here again.

Jan