From: "Jan Beulich" <jbeulich@novell.com>
To: konrad.wilk@oracle.com
Cc: jeremy@goop.org, xen-devel@lists.xensource.com
Subject: Re: [GIT PULL] for-2.6.32/bug-fixes
Date: Wed, 18 May 2011 07:22:39 +0100 [thread overview]
Message-ID: <4DD373C0020000780007014D@vpn.id2.novell.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 969 bytes --]
>>> Konrad Rzeszutek Wilk 05/17/11 6:44 PM >>>
>On Tue, May 17, 2011 at 05:24:43PM +0100, Jan Beulich wrote:
>> >>> On 17.05.11 at 17:57, Konrad Rzeszutek Wilk wrote:
>> >> > No attaching of data to the barrier.
>> >>
>> >> Sure, this direction we agree about. But your change is enforcing
>> >> it the other way around (if barrier then no data), which wasn't the
>> >> case so far.
>> >
>> > OK, even if the code that actually does the bio submission does
>> > not attach any data to the bio? The end result is the same - no
>> > data with barriers.
>>
>> My problem is that I can't see where attaching data would be
>> skipped. The only thing I see is the BUG_ON() you pointed at
>
>Well, req->ns_segments = 0, so nseg is zero, which means all
>of those for loops never get executed.
This you say is the case for the request you saw the failure with, or
*all* barrier requests? In the latter case, what do you conclude this
from?
Jan
[-- Attachment #1.2: HTML --]
[-- Type: text/html, Size: 1468 bytes --]
[-- Attachment #2: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next reply other threads:[~2011-05-18 6:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 6:22 Jan Beulich [this message]
2011-05-18 13:24 ` [GIT PULL] for-2.6.32/bug-fixes Konrad Rzeszutek Wilk
2011-05-18 14:31 ` Jan Beulich
2011-05-18 14:56 ` Konrad Rzeszutek Wilk
2011-05-18 15:03 ` Jan Beulich
2011-05-18 15:13 ` Konrad Rzeszutek Wilk
2011-05-18 15:23 ` Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2011-05-16 20:35 Konrad Rzeszutek Wilk
2011-05-17 9:48 ` Jan Beulich
2011-05-17 10:07 ` Jan Beulich
2011-05-17 14:16 ` Konrad Rzeszutek Wilk
2011-05-17 15:06 ` Jan Beulich
2011-05-17 15:57 ` Konrad Rzeszutek Wilk
2011-05-17 16:24 ` Jan Beulich
2011-05-17 16:43 ` Konrad Rzeszutek Wilk
2011-01-27 18:52 Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD373C0020000780007014D@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).