From: Wei Huang <wei.huang2@amd.com>
To: Keir Fraser <keir.xen@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] retry instruction on svm emulation failure
Date: Wed, 18 May 2011 16:08:02 -0500 [thread overview]
Message-ID: <4DD43532.7010305@amd.com> (raw)
In-Reply-To: <C9F9592E.1A832%keir.xen@gmail.com>
I don't think we can take this patch before understanding what is going
on. As Keir said, could you share a sample code or failure case? so we
can debug it.
Thanks,
-Wei
On 05/18/2011 05:08 AM, Keir Fraser wrote:
> On 18/05/2011 10:05, "Paolo Bonzini"<pbonzini@redhat.com> wrote:
>
>> retry instruction on svm emulation failure
>>
>> Upon emulation failure, Xen injects a #GP into the guest on AMD machines.
>> However, this kind of #GP does not happen in hardware. It is possible
>> (and was observed in practice) that the failure is transient. It will
>> go away naturally if the instruction is retried, because the guest will
>> be executing other code and will not exit.
> It begs the question why we were emulating the instruction in the first
> place. I'd like to see further explanation, with a concrete example, before
> applying this patch. Or get an Ack from an AMD maintainer.
>
> -- Keir
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
prev parent reply other threads:[~2011-05-18 21:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 9:05 [PATCH] retry instruction on svm emulation failure Paolo Bonzini
2011-05-18 10:08 ` Keir Fraser
2011-05-18 21:08 ` Wei Huang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD43532.7010305@amd.com \
--to=wei.huang2@amd.com \
--cc=keir.xen@gmail.com \
--cc=pbonzini@redhat.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).