From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Huang Subject: Re: [PATCH] retry instruction on svm emulation failure Date: Wed, 18 May 2011 16:08:02 -0500 Message-ID: <4DD43532.7010305@amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Paolo Bonzini , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org I don't think we can take this patch before understanding what is going on. As Keir said, could you share a sample code or failure case? so we can debug it. Thanks, -Wei On 05/18/2011 05:08 AM, Keir Fraser wrote: > On 18/05/2011 10:05, "Paolo Bonzini" wrote: > >> retry instruction on svm emulation failure >> >> Upon emulation failure, Xen injects a #GP into the guest on AMD machines. >> However, this kind of #GP does not happen in hardware. It is possible >> (and was observed in practice) that the failure is transient. It will >> go away naturally if the instruction is retried, because the guest will >> be executing other code and will not exit. > It begs the question why we were emulating the instruction in the first > place. I'd like to see further explanation, with a concrete example, before > applying this patch. Or get an Ack from an AMD maintainer. > > -- Keir > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >