From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@novell.com>
Subject: Re: [PATCH 29 of 45] gcc-4.6 compile fix:
	xen/arch/x86/cpu/intel.c
Date: Fri, 20 May 2011 08:55:42 +0100
Message-ID: <4DD63A9E0200007800042615@vpn.id2.novell.com>
References: <patchbomb.1305831919@probook.site>
	<30c6a8c61c90f896ba2e.1305831948@probook.site>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <30c6a8c61c90f896ba2e.1305831948@probook.site>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Olaf Hering <olaf@aepfle.de>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

>>> On 19.05.11 at 21:05, Olaf Hering <olaf@aepfle.de> wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1305824415 -7200
> # Node ID 30c6a8c61c90f896ba2ef9ee2f4f417cea7c1ffa
> # Parent  c8e4a190705be60bae9cff30c90a8a4a307979ec
> gcc-4.6 compile fix: xen/arch/x86/cpu/intel.c
>=20
> intel.c: In function 'set_cpuidmask':
> intel.c:36:14: error: variable 'extra' set but not used=20
> [-Werror=3Dunused-but-set-variable]

No, please don't push this - it was a mistake that "extra" wasn't
used, and http://lists.xensource.com/archives/html/xen-devel/2011-05/msg007=
53.html=20
corrects this.

Jan

> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>=20
> diff -r c8e4a190705b -r 30c6a8c61c90 xen/arch/x86/cpu/intel.c
> --- a/xen/arch/x86/cpu/intel.c	Thu May 19 19:00:14 2011 +0200
> +++ b/xen/arch/x86/cpu/intel.c	Thu May 19 19:00:15 2011 +0200
> @@ -33,8 +33,6 @@ struct movsl_mask movsl_mask __read_most
>   */
>  static void __devinit set_cpuidmask(const struct cpuinfo_x86 *c)
>  {
> -	const char *extra =3D "";
> -
>  	if (!~(opt_cpuid_mask_ecx & opt_cpuid_mask_edx &
>  	       opt_cpuid_mask_ext_ecx & opt_cpuid_mask_ext_edx))
>  		return;
> @@ -51,7 +49,6 @@ static void __devinit set_cpuidmask(cons
>  		      opt_cpuid_mask_edx);
>  		if (!~(opt_cpuid_mask_ext_ecx & opt_cpuid_mask_ext_edx))
>  			return;
> -		extra =3D "extended ";
>  		break;
>  /*=20
>   * CPU supports this feature if the processor signature meets the=20
> following:
>=20
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com=20
> http://lists.xensource.com/xen-devel=20