From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: [PATCH] xen: cleanup headers
Date: Mon, 23 May 2011 11:17:11 +0200
Message-ID: <4DDA2617.7060708@amd.com>
References: <C9FC38DC.1AA4B%keir.xen@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C9FC38DC.1AA4B%keir.xen@gmail.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.xen@gmail.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 05/20/11 16:27, Keir Fraser wrote:
> On 20/05/2011 13:58, "Christoph Egger"<Christoph.Egger@amd.com>  wrote:
>
>>
>> Include headers that are actually needed, drop everything else.
>
>> Do not use BUG() in public headers.
>
> Why would that be a problem in an ifdef-__XEN__ region?
>
>   -- Keir

Why is an ifdef-__XEN__ region needed at all in a public header ?

Christoph


>> Signed-off-by: Christoph Egger<Christoph.Egger@amd.com>
>
>
>


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632