tools/libfsimage: build fix

tools/libfsimage: build fix

[Christoph Egger]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]


Fix warning: array subscript has type 'char'

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

[-- Attachment #2: xen_tools_libfsimage.diff --]
[-- Type: text/plain, Size: 793 bytes --]

diff -r 87ff9d4de6f0 tools/libfsimage/xfs/fsys_xfs.c
--- a/tools/libfsimage/xfs/fsys_xfs.c	Wed May 25 16:04:56 2011 +0200
+++ b/tools/libfsimage/xfs/fsys_xfs.c	Wed May 25 16:17:03 2011 +0200
@@ -571,7 +571,7 @@ xfs_dir (fsi_file_t *ffi, char *dirname)
 			continue;
 		}
 
-		if (!*dirname || isspace (*dirname)) {
+		if (!*dirname || isspace ((uint8_t)*dirname)) {
 			if ((di_mode & IFMT) != IFREG) {
 				errnum = ERR_BAD_FILETYPE;
 				return 0;
@@ -588,7 +588,8 @@ xfs_dir (fsi_file_t *ffi, char *dirname)
 
 		for (; *dirname == '/'; dirname++);
 
-		for (rest = dirname; (ch = *rest) && !isspace (ch) && ch != '/'; rest++);
+		for (rest = dirname; (ch = *rest)
+                   && !isspace ((uint8_t)ch) && ch != '/'; rest++);
 		*rest = 0;
 
 		name = first_dentry (ffi, &new_ino);

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: tools/libfsimage: build fix

[Ian Jackson]

Christoph Egger writes ("[Xen-devel] tools/libfsimage: build fix"):
> Fix warning: array subscript has type 'char'
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>

Thanks.  You should probably also talk to the upstream for this code,
which AIUI is grub, to have it fixed there.

Ian.