From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH V2] xenconsole: add file lock to xenconsole
Date: Fri, 27 May 2011 10:04:05 +0200
Message-ID: <4DDF5AF5.1040701@redhat.com>
References: <1306466202-4625-1-git-send-email-yufang521247@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1306466202-4625-1-git-send-email-yufang521247@gmail.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Yufang Zhang <yufang521247@gmail.com>
Cc: Yufang Zhang <yuzhang@redhat.com>, lersek@redhat.com, xen-devel@lists.xensource.com, Ian.Jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On 05/27/2011 05:16 AM, Yufang Zhang wrote:
> @@ -280,6 +302,7 @@ int main(int argc, char **argv)
>   	int spty, xsfd;
>   	struct xs_handle *xs;
>   	char *end;
> +	char buf[100];
>   	console_type type = CONSOLE_INVAL;
>
>   	while((ch = getopt_long(argc, argv, sopt, lopt,&opt_ind)) != -1) {
> @@ -368,6 +391,13 @@ int main(int argc, char **argv)
>   		exit(EINVAL);
>   	}
>
> +	/* Make sure only one console is attached to guest */
> +	snprintf(buf, strlen("/var/run/xenconsole-%d-%d") + 1, "/var/run/xenconsole-%d-%d", domid, num);
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This should be sizeof(buf).

Otherwise looks good to me.

Paolo