xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Egger <Christoph.Egger@amd.com>
To: Keir Fraser <keir@xen.org>
Cc: Tim Deegan <Tim.Deegan@eu.citrix.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] xen: Deal with stdarg.h and -nostdinc
Date: Fri, 27 May 2011 16:05:47 +0200	[thread overview]
Message-ID: <4DDFAFBB.50607@amd.com> (raw)
In-Reply-To: <CA05620F.2DB3F%keir@xen.org>

On 05/27/11 15:13, Keir Fraser wrote:
> On 27/05/2011 10:48, "Christoph Egger"<Christoph.Egger@amd.com>  wrote:
>
>>> Finally, rather than referencing a hardcoded /usr/include path or including
>>> gcc intrinsics in xen/stdarg.h, would *BSD prefer a -isystem command-line
>>> option to include the gcc headers in the search path? Then we could perhaps
>>> even get rid of xen/stdarg.h completely.
>>
>> NetBSD is about to add clang/llvm support. If -isystem works for both
>> gcc and clang then this should be fine.
>
> Something like the attached patch? I don't know whether this would work for
> clang too -- cc'ing Tim who will know or can try it out.
>
> I wouldn't backport this one to 4.1, but my first patch was a cleanup plus
> BSD-specific changes, so a variant on that would be suitable for 4.0/4.1,
> with (if it works) this new one in unstable.

$ clang -print-file-name=include
include
$ gcc -print-file-name=include
include
$ gcc -print-file-name=a
a
$

I got two variants working:
a) use -nostdinc and map the stdarg usage to the gcc builtins
b) do not use -nostdinc on NetBSD

Both 0?-stdarg-fixes work with a minor
modification to match case a) or case b).

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

  reply	other threads:[~2011-05-27 14:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CA052B9C.2DB31%keir@xen.org>
2011-05-27  9:48 ` [PATCH] xen: Deal with stdarg.h and -nostdinc Christoph Egger
2011-05-27 13:13   ` Keir Fraser
2011-05-27 14:05     ` Christoph Egger [this message]
2011-05-27 14:41       ` Keir Fraser
2011-05-27 14:51       ` Keir Fraser
2011-05-27 15:08         ` Christoph Egger
2011-05-27 13:16   ` Tim Deegan
2011-05-27 13:19     ` Keir Fraser
2011-05-27 13:27       ` Tim Deegan
2011-05-27 13:30       ` Ian Campbell
2011-05-26 14:54 Christoph Egger
2011-05-26 15:00 ` Christoph Egger
2011-05-26 15:17 ` Keir Fraser
2011-05-26 15:19 ` Jan Beulich
2011-05-26 16:11 ` Ian Jackson
2011-05-26 17:08   ` Keir Fraser
2011-05-27  7:55     ` Christoph Egger
2011-05-27  8:46       ` Keir Fraser
2011-05-27  8:59         ` Christoph Egger
2011-05-27 10:57       ` Ian Jackson
2011-05-27  7:47   ` Christoph Egger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DDFAFBB.50607@amd.com \
    --to=christoph.egger@amd.com \
    --cc=Tim.Deegan@eu.citrix.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).