xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: Xin Li <xin.li@intel.com>
Cc: Keir Fraser <keir.xen@gmail.com>,
	xen-devel <xen-devel@lists.xensource.com>
Subject: RE: [PATCH] CPUID level 0x00000007:0 (ebx) is word 9, instead of word 7
Date: Wed, 01 Jun 2011 07:35:57 +0100	[thread overview]
Message-ID: <4DE5F9ED0200007800044BCD@vpn.id2.novell.com> (raw)
In-Reply-To: <FC2FB65B4D919844ADE4BE3C2BB739AD5AB17B78@shsmsx501.ccr.corp.intel.com>

>>> On 31.05.11 at 16:59, "Li, Xin" <xin.li@intel.com> wrote:
>> can't see why we would need to stay in sync with Linux's capability
>> array indices.
> 
> why?  Typically we reuse Linux code unless Xen has its special logic.

So you would suggest leaving indices 7 and 8 unused instead?
Looking at current Linux, we certainly could convert Xen to use
index 8 for virtualization features, but since these are being
tracked differently already anyway I don't see a value in this.

As to index 7, just look at ARAT - we're already diverging from
Linux here (having it allocated in index 3).

Bottom line is that I think keeping the names (and in various cases
the grouping together, namely when the bits are grouped together
in some CPUID leaf's output) in sync is desirable, but following
Linux to the bit doesn't always make sense. After all, some thinking
will always be necessary when porting over patches.

Jan

  reply	other threads:[~2011-06-01  6:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-30 23:39 [PATCH] CPUID level 0x00000007:0 (ebx) is word 9, instead of word 7 Li, Xin
2011-05-31 12:39 ` Keir Fraser
2011-05-31 12:54   ` Jan Beulich
2011-05-31 14:59     ` Li, Xin
2011-06-01  6:35       ` Jan Beulich [this message]
2011-06-01  6:47         ` Keir Fraser
2011-06-01 14:41           ` Li, Xin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DE5F9ED0200007800044BCD@vpn.id2.novell.com \
    --to=jbeulich@novell.com \
    --cc=keir.xen@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=xin.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).