From: "Jan Beulich" <JBeulich@novell.com>
To: Pradeep Vincent <pradeepv@amazon.com>
Cc: Xen <xen-devel@lists.xensource.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
Daniel Stodden <daniel.stodden@citrix.com>
Subject: Re: [PATCH] xen/blkback: Don't let in-flight requests defer pending ones.
Date: Wed, 01 Jun 2011 09:24:15 +0100 [thread overview]
Message-ID: <4DE6134F0200007800044CA7@vpn.id2.novell.com> (raw)
In-Reply-To: <CA0B31CB.18CDA%pradeepv@amazon.com>
>>> On 01.06.11 at 10:02, "Vincent, Pradeep" <pradeepv@amazon.com> wrote:
> Re: Locking
>
> I was reflecting Jan Beulich's comment earlier in this thread. Like I said
> before (in this thread), the locking logic in blkback isn't obvious from
> the code and the failure modes seem benign. If someone has good context on
> blkback locking strategy, I would love to learn. Also it would be very
> useful to add some comments around lock usage to the blkback code.
>
> Jan ??
No, not really - I'm more of an observer on this and similar
discussions, just trying to learn as much as I can. Now and then I
do notice possible issues, but as the design and the reasons for
the choices made aren't (afaik, and like you also say) documented,
a lot of room for guessing is usually left.
Jan
next prev parent reply other threads:[~2011-06-01 8:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 7:04 [PATCH] blkback: Fix block I/O latency issue Vincent, Pradeep
2011-05-02 8:13 ` Jan Beulich
2011-05-03 1:10 ` Vincent, Pradeep
2011-05-03 14:55 ` Konrad Rzeszutek Wilk
2011-05-03 17:16 ` Vincent, Pradeep
2011-05-03 17:51 ` Daniel Stodden
2011-05-03 23:41 ` Vincent, Pradeep
2011-05-03 17:52 ` Daniel Stodden
2011-05-04 1:54 ` Vincent, Pradeep
2011-05-09 20:24 ` Konrad Rzeszutek Wilk
2011-05-13 0:40 ` Vincent, Pradeep
2011-05-13 2:51 ` Konrad Rzeszutek Wilk
2011-05-16 15:22 ` Konrad Rzeszutek Wilk
2011-05-20 6:12 ` Vincent, Pradeep
2011-05-24 16:02 ` Konrad Rzeszutek Wilk
2011-05-24 22:40 ` Vincent, Pradeep
2011-05-28 20:12 ` [RE-PATCH] " Daniel Stodden
2011-05-28 20:21 ` [PATCH] xen/blkback: Don't let in-flight requests defer pending ones Daniel Stodden
2011-05-29 8:09 ` Vincent, Pradeep
2011-05-29 11:34 ` Daniel Stodden
2011-06-01 8:02 ` Vincent, Pradeep
2011-06-01 8:24 ` Jan Beulich [this message]
2011-06-01 17:49 ` Daniel Stodden
2011-06-01 18:07 ` Daniel Stodden
2011-06-27 14:03 ` Konrad Rzeszutek Wilk
2011-06-27 18:42 ` Daniel Stodden
2011-06-27 19:13 ` Konrad Rzeszutek Wilk
2011-06-28 0:31 ` Daniel Stodden
2011-06-28 13:19 ` Konrad Rzeszutek Wilk
2011-05-31 13:44 ` Fix wrong help message for parameter nestedhvm Dong, Eddie
2011-05-31 16:23 ` Ian Campbell
2011-05-31 16:08 ` [PATCH] xen/blkback: Don't let in-flight requests defer pending ones Konrad Rzeszutek Wilk
2011-05-31 16:30 ` Daniel Stodden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE6134F0200007800044CA7@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=daniel.stodden@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=pradeepv@amazon.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).